Skip to content

NIFI-7498 Adding unique prefix to every swagger operationId#4310

Closed
EndzeitBegins wants to merge 1 commit into
apache:masterfrom
EndzeitBegins:nifi-7498
Closed

NIFI-7498 Adding unique prefix to every swagger operationId#4310
EndzeitBegins wants to merge 1 commit into
apache:masterfrom
EndzeitBegins:nifi-7498

Conversation

@EndzeitBegins
Copy link
Copy Markdown
Contributor

@EndzeitBegins EndzeitBegins commented May 31, 2020

Description of PR

Adds a prefix consisting of package and class name to every operationId to ensure it is unique.
The problem this fixes is desribed in NIFI-7498.

The prefix can be excluded in the method name when generating a client by using the flag --remove-operation-id-prefix (both openapi-generator and swagger-codegen).

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?
  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
  • Has your PR been rebased against the latest commit within the target branch (typically master)?
  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on JDK 8?
  • Have you verified that the full build is successful on JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

@github-actions
Copy link
Copy Markdown

We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be closed. This stale marker and eventual auto close does not indicate a judgement of the PR just lack of reviewer bandwidth and helps us keep the PR queue more manageable. If you would like this PR re-opened you can do so and a committer can remove the stale tag. Or you can open a new PR. Try to help review other PRs to increase PR review bandwidth which in turn helps yours.

@github-actions github-actions Bot added the Stale label Apr 25, 2021
@github-actions github-actions Bot closed this May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant