NIFI-7190 CaptureChangeMySQL processor remove comments from normalize…

[agentdalecoper]

…d query.

Thank you for submitting a contribution to Apache NiFi.

Please provide a short description of the PR here:
Remove comments from the normalized string of the mysql query to detect DDL.
https://issues.apache.org/jira/browse/NIFI-7190

Description of PR

Enables X functionality; fixes bug NIFI-YYYY.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

• Is there a JIRA ticket associated with this PR? Is it referenced
  in the commit message?

• Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

• Has your PR been rebased against the latest commit within the target branch (typically master)?

• Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

• Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
• Have you written or updated unit tests to verify your changes?
• Have you verified that the full build is successful on JDK 8?
• Have you verified that the full build is successful on JDK 11?
• If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
• If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
• If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
• If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

• Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

[agentdalecoper]

The other option would be to use normalizedQuery.contains("alter table") instead of filtering out the comments and other things with normalizedQuery.startsWith("alter table")

[pvillard31]

Thanks @feitgraph for the pull request, two comments:

• is there a way to extract the Pattern object to have the compile statement only once when the class is initialized? Can probably be added as a static object to the class.
• is it possible to add a unit test to confirm the behavior of this new normalization method?

[agentdalecoper]

@pvillard31
Thanks for reviewing, will come back with test then.

[github-actions]

We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be closed. This stale marker and eventual auto close does not indicate a judgement of the PR just lack of reviewer bandwidth and helps us keep the PR queue more manageable. If you would like this PR re-opened you can do so and a committer can remove the stale tag. Or you can open a new PR. Try to help review other PRs to increase PR review bandwidth which in turn helps yours.

[mattyb149]

This PR appears abandoned, I retained the original commit and submitted #6711 to get this across the finish line. Thank you for your contribution!