Skip to content

NIFI-7595 Upgrade log4j-core dependency.#4382

Closed
mtien-apache wants to merge 1 commit intoapache:masterfrom
mtien-apache:NIFI-7595
Closed

NIFI-7595 Upgrade log4j-core dependency.#4382
mtien-apache wants to merge 1 commit intoapache:masterfrom
mtien-apache:NIFI-7595

Conversation

@mtien-apache
Copy link
Copy Markdown
Contributor

Thank you for submitting a contribution to Apache NiFi.

Please provide a short description of the PR here:

Description of PR

Upgrade log4j-core dependency to 2.13.3.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on JDK 8?
  • Have you verified that the full build is successful on JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

@alopresto
Copy link
Copy Markdown
Contributor

I'm going to let the other CI/CD builds finish, but I have no idea why the failing Groovy test occurred on the MacOS build. That test has been running stably for some time.

Copy link
Copy Markdown
Contributor

@MikeThomsen MikeThomsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alopresto I kicked off the CI/CD runs again and we have 4/4.

@asfgit asfgit closed this in 74b4d5a Jul 7, 2020
tpalfy pushed a commit to tpalfy/nifi that referenced this pull request Jul 7, 2020
This closes apache#4382

Signed-off-by: Mike Thomsen <mthomsen@apache.org>
simonbence pushed a commit to simonbence/nifi that referenced this pull request Jul 9, 2020
This closes apache#4382

Signed-off-by: Mike Thomsen <mthomsen@apache.org>
Wastack pushed a commit to Wastack/nifi that referenced this pull request Jul 20, 2020
This closes apache#4382

Signed-off-by: Mike Thomsen <mthomsen@apache.org>
ets pushed a commit to ets/nifi that referenced this pull request Oct 2, 2020
This closes apache#4382

Signed-off-by: Mike Thomsen <mthomsen@apache.org>
driesva pushed a commit to driesva/nifi that referenced this pull request Mar 19, 2021
This closes apache#4382

Signed-off-by: Mike Thomsen <mthomsen@apache.org>
krisztina-zsihovszki pushed a commit to krisztina-zsihovszki/nifi that referenced this pull request Jun 28, 2022
This closes apache#4382

Signed-off-by: Mike Thomsen <mthomsen@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants