Skip to content

NIFI-7497 Removed a few style check bugs that crept up in the last co…#4402

Merged
bbende merged 1 commit into
apache:mainfrom
MikeThomsen:NIFI-7497
Jul 13, 2020
Merged

NIFI-7497 Removed a few style check bugs that crept up in the last co…#4402
bbende merged 1 commit into
apache:mainfrom
MikeThomsen:NIFI-7497

Conversation

@MikeThomsen
Copy link
Copy Markdown
Contributor

…mmit.

Thank you for submitting a contribution to Apache NiFi.

Please provide a short description of the PR here:

Description of PR

Enables X functionality; fixes bug NIFI-YYYY.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on JDK 8?
  • Have you verified that the full build is successful on JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

Copy link
Copy Markdown
Contributor

@bbende bbende left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, will merge

@bbende bbende merged commit bb5e9fb into apache:main Jul 13, 2020
driesva pushed a commit to driesva/nifi that referenced this pull request Mar 19, 2021
nabmoh123 pushed a commit to nabmoh123/nifi that referenced this pull request Apr 6, 2021
sputnik13 pushed a commit to sputnik13/nifi that referenced this pull request Jul 21, 2021
@MikeThomsen MikeThomsen deleted the NIFI-7497 branch August 14, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants