Skip to content

NIFI-7630 Upgraded H2 dependency.#4404

Closed
MikeThomsen wants to merge 2 commits intoapache:mainfrom
MikeThomsen:NIFI-7630
Closed

NIFI-7630 Upgraded H2 dependency.#4404
MikeThomsen wants to merge 2 commits intoapache:mainfrom
MikeThomsen:NIFI-7630

Conversation

@MikeThomsen
Copy link
Contributor

Thank you for submitting a contribution to Apache NiFi.

Please provide a short description of the PR here:

Description of PR

Enables X functionality; fixes bug NIFI-YYYY.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on JDK 8?
  • Have you verified that the full build is successful on JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

@MikeThomsen
Copy link
Contributor Author

mvn dependency:tree did not reveal any dependencies that would have L&N implications that I could see.

@bbende
Copy link
Contributor

bbende commented Jul 11, 2020

Let’s make sure we take an existing nifi with the old H2 Db and test dropping in the new NAR to make sure reading the old DB with the new H2 works. I’ve seen an issue before going to .200

@MikeThomsen
Copy link
Contributor Author

Do you remember what that issue was?

@MikeThomsen
Copy link
Contributor Author

@bbende I was getting that weird error with .198-.200, so I switched to .197 as a compromise for now.

Copy link
Contributor

@pvillard31 pvillard31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are using 1.4.199 in NiFi Registry, would it make sense to use the same version here? I know we saw some issues with 1.4.200 but 1.4.199 should be fine. Thoughts @bbende ?

Just noticed your comment @MikeThomsen... What issue did you see with .198-.200?
I'm fine with upgrading to .197 though, just checking if consistency is possible (even if it's definitely not a requirement).

@bbende
Copy link
Contributor

bbende commented Jul 17, 2020

I would have expected 199 to work, but I also haven't tested any upgrade paths for NiFi.

@MikeThomsen MikeThomsen closed this Nov 8, 2020
@MikeThomsen MikeThomsen deleted the NIFI-7630 branch August 14, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants