Skip to content

NIFI-7657 Suppressed log messages from failed authentication requests when HTTPS is not enabled#4418

Closed
alopresto wants to merge 2 commits intoapache:mainfrom
alopresto:NIFI-7657
Closed

NIFI-7657 Suppressed log messages from failed authentication requests when HTTPS is not enabled#4418
alopresto wants to merge 2 commits intoapache:mainfrom
alopresto:NIFI-7657

Conversation

@alopresto
Copy link
Contributor

Thank you for submitting a contribution to Apache NiFi.

Please provide a short description of the PR here:

Description of PR

NiFi UI would make requests for authentication even when HTTPS is disabled and therefore no authentication is enabled. When these (expected) messages appeared in the nifi-user.log, they would often confuse users. This PR removes those messages by default.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on JDK 8?
  • Have you verified that the full build is successful on JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

@alopresto
Copy link
Contributor Author

Re-running CI jobs as the Maven failures should be resolved thanks to PR 4419.

…on calls to HTTP NiFi server.

Added exception mapper.
…thentication not supported.

Registered exception mapper.
@alopresto
Copy link
Contributor Author

Had to rebase on main to include the fix; now CI jobs are running again.

@pvillard31
Copy link
Contributor

Gave it a try and it LGTM. Merging to main, thanks @alopresto

@asfgit asfgit closed this in 78d88b4 Jul 22, 2020
ets pushed a commit to ets/nifi that referenced this pull request Oct 2, 2020
…on calls to HTTP NiFi server.

Added exception mapper.

NIFI-7657 Renamed exception & exception mapper to reflect scope of authentication not supported.
Registered exception mapper.

Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com>

This closes apache#4418.
driesva pushed a commit to driesva/nifi that referenced this pull request Mar 19, 2021
…on calls to HTTP NiFi server.

Added exception mapper.

NIFI-7657 Renamed exception & exception mapper to reflect scope of authentication not supported.
Registered exception mapper.

Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com>

This closes apache#4418.
krisztina-zsihovszki pushed a commit to krisztina-zsihovszki/nifi that referenced this pull request Jun 28, 2022
…on calls to HTTP NiFi server.

Added exception mapper.

NIFI-7657 Renamed exception & exception mapper to reflect scope of authentication not supported.
Registered exception mapper.

Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com>

This closes apache#4418.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants