Skip to content

NIFI-7751 - fix for TestExecuteStreamCommand unit tests#4483

Closed
pvillard31 wants to merge 1 commit intoapache:mainfrom
pvillard31:NIFI-7751
Closed

NIFI-7751 - fix for TestExecuteStreamCommand unit tests#4483
pvillard31 wants to merge 1 commit intoapache:mainfrom
pvillard31:NIFI-7751

Conversation

@pvillard31
Copy link
Contributor

@pvillard31 pvillard31 commented Aug 19, 2020

Thank you for submitting a contribution to Apache NiFi.

Please provide a short description of the PR here:

Description of PR

Enables X functionality; fixes bug NIFI-YYYY.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on JDK 8?
  • Have you verified that the full build is successful on JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

@pvillard31 pvillard31 marked this pull request as draft August 19, 2020 09:13
@pvillard31 pvillard31 marked this pull request as ready for review August 19, 2020 10:22
@ottobackwards
Copy link
Contributor

+1, any idea why this was coming up now?

@pvillard31
Copy link
Contributor Author

it seems to be related to a JDK upgrade in the Github actions but could not reproduce locally

@asfgit asfgit closed this in d0c0f97 Aug 24, 2020
@joewitt
Copy link
Contributor

joewitt commented Aug 24, 2020

not about a JDK upgrade. or Maven. Or even the linux platform itself. See below of a run that passes and another that fails

FAILS
https://github.com/apache/nifi/runs/995697606?check_suite_focus=true
build with Maven38m 23s
MAVEN_OPTS: -Xmx2g -XX:ReservedCodeCacheSize=1g -XX:+UseG1GC -Dorg.slf4j.simpleLogger.defaultLogLevel=WARN -Dmaven.surefire.arguments="-Duser.language=fr -Duser.region=FR -Duser.timezone=Europe/Paris"
Run mvn -V -T 0.8C package verify -B -Pcontrib-check,include-grpc -Ddir-only -ntp -ff -pl -nifi-assembly,-nifi-toolkit/nifi-toolkit-assembly,-nifi-system-tests -nsu
mvn -V -T 0.8C package verify -B -Pcontrib-check,include-grpc -Ddir-only -ntp -ff -pl -nifi-assembly,-nifi-toolkit/nifi-toolkit-assembly,-nifi-system-tests -nsu
shell: /bin/bash -e {0}
env:
JAVA_HOME: /opt/hostedtoolcache/jdk/8.0.265/x64
JAVA_HOME_8.0.265_x64: /opt/hostedtoolcache/jdk/8.0.265/x64
MAVEN_OPTS: -Xmx2g -XX:ReservedCodeCacheSize=1g -XX:+UseG1GC -Dorg.slf4j.simpleLogger.defaultLogLevel=WARN -Dmaven.surefire.arguments="-Duser.language=fr -Duser.region=FR -Duser.timezone=Europe/Paris"
Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Maven home: /usr/share/apache-maven-3.6.3
Java version: 1.8.0_265, vendor: Azul Systems, Inc., runtime: /opt/hostedtoolcache/jdk/8.0.265/x64/jre
Default locale: en_FR, platform encoding: UTF8
OS name: "linux", version: "5.3.0-1034-azure", arch: "amd64", family: "unix"
[WARNING] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8

PASSES
https://github.com/apache/nifi/actions/runs/207620028

Build with Maven48m 45s
MAVEN_OPTS: -Xmx2g -XX:ReservedCodeCacheSize=1g -XX:+UseG1GC -Dorg.slf4j.simpleLogger.defaultLogLevel=WARN -Dmaven.surefire.arguments="-Duser.language=fr -Duser.region=FR -Duser.timezone=Europe/Paris"
Run mvn -V -T 0.8C package verify -B -Pcontrib-check,include-grpc -Ddir-only -ntp -ff -pl -nifi-assembly,-nifi-toolkit/nifi-toolkit-assembly,-nifi-system-tests -nsu
mvn -V -T 0.8C package verify -B -Pcontrib-check,include-grpc -Ddir-only -ntp -ff -pl -nifi-assembly,-nifi-toolkit/nifi-toolkit-assembly,-nifi-system-tests -nsu
shell: /bin/bash -e {0}
env:
JAVA_HOME: /opt/hostedtoolcache/jdk/8.0.265/x64
JAVA_HOME_8.0.265_x64: /opt/hostedtoolcache/jdk/8.0.265/x64
MAVEN_OPTS: -Xmx2g -XX:ReservedCodeCacheSize=1g -XX:+UseG1GC -Dorg.slf4j.simpleLogger.defaultLogLevel=WARN -Dmaven.surefire.arguments="-Duser.language=fr -Duser.region=FR -Duser.timezone=Europe/Paris"
Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Maven home: /usr/share/apache-maven-3.6.3
Java version: 1.8.0_265, vendor: Azul Systems, Inc., runtime: /opt/hostedtoolcache/jdk/8.0.265/x64/jre
Default locale: en_FR, platform encoding: UTF-8
OS name: "linux", version: "5.3.0-1034-azure", arch: "amd64", family: "unix"

....so there is something else different in the config of the systems.

@joewitt
Copy link
Contributor

joewitt commented Aug 24, 2020

good and likely relevant find by @kevdoran actions/runner-images#1437

asfgit pushed a commit that referenced this pull request Sep 2, 2020
…tests

Signed-off-by: Joe Witt <joewitt@apache.org>
driesva pushed a commit to driesva/nifi that referenced this pull request Mar 19, 2021
… unit tests

Signed-off-by: Joe Witt <joewitt@apache.org>
krisztina-zsihovszki pushed a commit to krisztina-zsihovszki/nifi that referenced this pull request Jun 28, 2022
… unit tests

Signed-off-by: Joe Witt <joewitt@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants