NIFI-7592: Allow NiFi to be started without a GUI/REST interface#4509
NIFI-7592: Allow NiFi to be started without a GUI/REST interface#4509bbende merged 4 commits intoapache:mainfrom
Conversation
|
Thanks Matt. I will take a look soon but very excited to get this contribution. |
|
I'll review this as well. |
|
So far, from my perspective things look good @mattyb149 . One thing that I noticed, though, is that if you have processors that are stopped, the headless mode will go ahead and run those. Which makes sense because there's no way to start/stop the processors. But if the processor depends on a controller service, those controller services don't get automatically enabled. Do you think it makes sense to go ahead and enable Controller Services before starting the processors? |
|
Yeah makes sense for headless to enable the controller services since there's no UI to enable them. Then any dependent processors can start as you mentioned. Will add |
dd4c443 to
45ed5ce
Compare
3b23d23 to
86f1c69
Compare
bbende
left a comment
There was a problem hiding this comment.
Overall looks good, left a couple of minor comments.
One other comment is that there is a lot of overlap of dependencies between nifi-framework-nar and nifi-server-nar, and I'm wondering if we could reduce most of the dependencies in nifi-server-nar to include just the WARs and get everything else from the parent.
86f1c69 to
955086a
Compare
|
Updates look good, going to merge, thanks! |
…che#4509) * NIFI-7592: Allow NiFi to be started without a GUI/REST interface * NIFI-7592: Enable all controller services when starting headless * NIFI-7592: Marked duplicate dependencies as provided * NIFI-7592: Incorporated additional review comments
…che#4509) * NIFI-7592: Allow NiFi to be started without a GUI/REST interface * NIFI-7592: Enable all controller services when starting headless * NIFI-7592: Marked duplicate dependencies as provided * NIFI-7592: Incorporated additional review comments
…che#4509) * NIFI-7592: Allow NiFi to be started without a GUI/REST interface * NIFI-7592: Enable all controller services when starting headless * NIFI-7592: Marked duplicate dependencies as provided * NIFI-7592: Incorporated additional review comments
…che#4509) * NIFI-7592: Allow NiFi to be started without a GUI/REST interface * NIFI-7592: Enable all controller services when starting headless * NIFI-7592: Marked duplicate dependencies as provided * NIFI-7592: Incorporated additional review comments
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
New and improved version of a previous PR to move NARs and dependencies around such that NiFi could be started in a "headless" mode. Specifically it removes the requirement on JettyServer and instead moves that into nifi-server-nar and provides a reference implementation for a headless NiFi in nifi-headless-server-nar.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically
main)?Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not
squashor use--forcewhen pushing to allow for clean monitoring of changes.For code changes:
mvn -Pcontrib-check clean installat the rootnififolder?LICENSEfile, including the mainLICENSEfile undernifi-assembly?NOTICEfile, including the mainNOTICEfile found undernifi-assembly?.displayNamein addition to .name (programmatic access) for each of the new properties?For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.