Skip to content

NIFI-7592: Allow NiFi to be started without a GUI/REST interface#4509

Merged
bbende merged 4 commits intoapache:mainfrom
mattyb149:NIFI-7592
Oct 7, 2020
Merged

NIFI-7592: Allow NiFi to be started without a GUI/REST interface#4509
bbende merged 4 commits intoapache:mainfrom
mattyb149:NIFI-7592

Conversation

@mattyb149
Copy link
Copy Markdown
Contributor

Thank you for submitting a contribution to Apache NiFi.

Please provide a short description of the PR here:

Description of PR

New and improved version of a previous PR to move NARs and dependencies around such that NiFi could be started in a "headless" mode. Specifically it removes the requirement on JettyServer and instead moves that into nifi-server-nar and provides a reference implementation for a headless NiFi in nifi-headless-server-nar.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on JDK 8?
  • Have you verified that the full build is successful on JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

@alopresto
Copy link
Copy Markdown
Contributor

Thanks Matt. I will take a look soon but very excited to get this contribution.

@markap14
Copy link
Copy Markdown
Contributor

markap14 commented Sep 3, 2020

I'll review this as well.

@markap14
Copy link
Copy Markdown
Contributor

markap14 commented Sep 9, 2020

So far, from my perspective things look good @mattyb149 . One thing that I noticed, though, is that if you have processors that are stopped, the headless mode will go ahead and run those. Which makes sense because there's no way to start/stop the processors. But if the processor depends on a controller service, those controller services don't get automatically enabled. Do you think it makes sense to go ahead and enable Controller Services before starting the processors?

@mattyb149
Copy link
Copy Markdown
Contributor Author

Yeah makes sense for headless to enable the controller services since there's no UI to enable them. Then any dependent processors can start as you mentioned. Will add

Copy link
Copy Markdown
Contributor

@bbende bbende left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, left a couple of minor comments.

One other comment is that there is a lot of overlap of dependencies between nifi-framework-nar and nifi-server-nar, and I'm wondering if we could reduce most of the dependencies in nifi-server-nar to include just the WARs and get everything else from the parent.

@bbende
Copy link
Copy Markdown
Contributor

bbende commented Oct 7, 2020

Updates look good, going to merge, thanks!

@bbende bbende merged commit 325a495 into apache:main Oct 7, 2020
thenatog pushed a commit to thenatog/nifi that referenced this pull request Oct 9, 2020
…che#4509)

* NIFI-7592: Allow NiFi to be started without a GUI/REST interface

* NIFI-7592: Enable all controller services when starting headless

* NIFI-7592: Marked duplicate dependencies as provided

* NIFI-7592: Incorporated additional review comments
thenatog pushed a commit to thenatog/nifi that referenced this pull request Oct 20, 2020
…che#4509)

* NIFI-7592: Allow NiFi to be started without a GUI/REST interface

* NIFI-7592: Enable all controller services when starting headless

* NIFI-7592: Marked duplicate dependencies as provided

* NIFI-7592: Incorporated additional review comments
driesva pushed a commit to driesva/nifi that referenced this pull request Mar 19, 2021
…che#4509)

* NIFI-7592: Allow NiFi to be started without a GUI/REST interface

* NIFI-7592: Enable all controller services when starting headless

* NIFI-7592: Marked duplicate dependencies as provided

* NIFI-7592: Incorporated additional review comments
krisztina-zsihovszki pushed a commit to krisztina-zsihovszki/nifi that referenced this pull request Jun 28, 2022
…che#4509)

* NIFI-7592: Allow NiFi to be started without a GUI/REST interface

* NIFI-7592: Enable all controller services when starting headless

* NIFI-7592: Marked duplicate dependencies as provided

* NIFI-7592: Incorporated additional review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants