Skip to content

NIFI-7805 ResultSetRecordSet can't generate a schema if first row con…#4532

Closed
patricker wants to merge 1 commit into
apache:mainfrom
patricker:NIFI-7805
Closed

NIFI-7805 ResultSetRecordSet can't generate a schema if first row con…#4532
patricker wants to merge 1 commit into
apache:mainfrom
patricker:NIFI-7805

Conversation

@patricker
Copy link
Copy Markdown
Contributor

…tains NULL Decimal

Description of PR

When using ResultSetRecordSet, if the first row in a resultset contains a Decimal column with a NULL value, then NiFi fails to create a schema and throws an exception. This is because it is trying to read the Decimal Scale and Precision from the Decimal Value rather than from the Result Set Schema.

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on JDK 8?
  • Have you verified that the full build is successful on JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

@patricker
Copy link
Copy Markdown
Contributor Author

@tpalfy @markap14 @simonbence
Small bug fix for #4223. If you have a minute to look it over I'd appreciate it.

@simonbence
Copy link
Copy Markdown
Contributor

Good catch, LGTM

Copy link
Copy Markdown
Contributor

@pvillard31 pvillard31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review @simonbence, it LGTM as well @patricker, merging, thank you.

@asfgit asfgit closed this in 800655c Sep 16, 2020
asfgit pushed a commit that referenced this pull request Sep 16, 2020
…tains NULL Decimal

Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com>

This closes #4532.
driesva pushed a commit to driesva/nifi that referenced this pull request Mar 19, 2021
…tains NULL Decimal

Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com>

This closes apache#4532.
krisztina-zsihovszki pushed a commit to krisztina-zsihovszki/nifi that referenced this pull request Jun 28, 2022
…tains NULL Decimal

Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com>

This closes apache#4532.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants