Skip to content

NIFI-7650: Add basic focus management to UI#4542

Closed
sardell wants to merge 18 commits intoapache:mainfrom
sardell:NIFI-7650
Closed

NIFI-7650: Add basic focus management to UI#4542
sardell wants to merge 18 commits intoapache:mainfrom
sardell:NIFI-7650

Conversation

@sardell
Copy link
Contributor

@sardell sardell commented Sep 21, 2020

Thank you for submitting a contribution to Apache NiFi.

Please provide a short description of the PR here:

Description of PR

This PR adds some basic focus management to the NiFi UI. This helps those using assistive technologies or keyboards navigate interactive elements on a page. When testing, you’ll notice the following changes:


  • A user is now able to tab through all of the interactive controls on the canvas page. This includes the components toolbar, global menu, navigate palette and operate palette.
  • The global menu is now navigable via the up and down arrow keys.
  • Focus is now trapped inside of modals as described in the wai-aria modal best practices document, as well as some shell dialogs (for example, Bulletin Board and Templates). Unfortunately, SlickGrid applies tab index to hidden elements it generates, which in turn breaks the code that traps focus inside of shell dialogs. This can be resolved by contributing to SlickGrid or switching to another package in the future. I created a Jira ticket to track the issue.
  • I applied the same :hover styling to :focus where possible, but some elements (such as the breadcrumb and bulletin button) do not have :hover styling.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on JDK 8?
  • Have you verified that the full build is successful on JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

@sardell
Copy link
Contributor Author

sardell commented Dec 11, 2020

Closing this PR in favor of smaller PRs that are easier to test.

@sardell sardell closed this Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant