Skip to content

NIFI-7817 - Backport of Fix ParquetReader instantiation error (#4538)#4559

Closed
frankgh wants to merge 1 commit intoapache:support/nifi-1.12.xfrom
frankgh:NIFI-7817-backport
Closed

NIFI-7817 - Backport of Fix ParquetReader instantiation error (#4538)#4559
frankgh wants to merge 1 commit intoapache:support/nifi-1.12.xfrom
frankgh:NIFI-7817-backport

Conversation

@frankgh
Copy link
Copy Markdown

@frankgh frankgh commented Sep 29, 2020

Thank you for submitting a contribution to Apache NiFi.

Please provide a short description of the PR here:

Description of PR

Enables X functionality; fixes bug NIFI-YYYY.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on JDK 8?
  • Have you verified that the full build is successful on JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

@bbende
Copy link
Copy Markdown
Contributor

bbende commented Sep 29, 2020

@frankgh we don't need to submit this to the support branch, the way it works is that if the community decides to do another 1.12.x maintenance release (1.12.1 is already made and released yesterday), then the RM would go through all the tickets that landed in main (1.13.0-SNAPSHOT), and cherry-pick any bug fixes.

@frankgh
Copy link
Copy Markdown
Author

frankgh commented Sep 29, 2020

@bbende thanks for letting me know, will close this now in that case

@frankgh frankgh closed this Sep 29, 2020
@frankgh frankgh deleted the NIFI-7817-backport branch September 29, 2020 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants