NIFI-1905 enabled ExecuteProcess to terminate process #456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| executor.shutdown(); | ||
| } finally { | ||
| if (this.externalProcess.isAlive()) { | ||
| this.getLogger().warn("Interrupting external process since it did not finished at the time stop Processor was initiated."); |
Contributor
There was a problem hiding this comment.
Check for typos and wording, maybe simplify it? How about 'Process hasn't terminated on request, forcing the interrupt'?
Contributor
Author
There was a problem hiding this comment.
Fair, i'll change. Let me know when you get a chance to test it in your environment.
Contributor
Author
There was a problem hiding this comment.
Process hasn't terminated, forcing the interrupt. - that is what I am putting in now since we are actually issuing a request to stop something that has not terminated by itself yet. So, I've removed "on request".
NIFI-1905 polishing NIFI-1905 changed WARN to INFO during shutdown
Contributor
Author
|
@aperepel all squashed and pushed, including the change from WARN to INFO for log message. |
Contributor
|
LGTM, +1 on this one :) |
asfgit
pushed a commit
that referenced
this pull request
May 22, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.