Skip to content

NIFI-7884 Added and applied Distributed File System permissions#4713

Merged
bbende merged 1 commit intoapache:mainfrom
exceptionfactory:NIFI-7884
Dec 8, 2020
Merged

NIFI-7884 Added and applied Distributed File System permissions#4713
bbende merged 1 commit intoapache:mainfrom
exceptionfactory:NIFI-7884

Conversation

@exceptionfactory
Copy link
Contributor

Description of PR

NIFI-7884 Introduces READ_DISTRIBUTED_FILESYSTEM and WRITE_DISTRIBUTED_FILESYSTEM Required Permission values to distinguish annotated Processors from other Processors that are limited to accessing the local file system As indicated in the existing annotation explanations, these permissions imply access to both distributed file systems as well as local file systems. This update replaces permission definitions on the following Processors:

  • DeleteHDFS
  • FetchHDFS
  • GetHDFS
  • MoveHDFS
  • PutHDFS
  • PutORC
  • FetchParquet
  • PutParquet

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on JDK 8?
  • Have you verified that the full build is successful on JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

@bbende bbende self-requested a review December 8, 2020 20:56
Copy link
Contributor

@bbende bbende left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, verified the new restricted permission works as expected, going to merge, thanks!

@bbende bbende merged commit cfbcecc into apache:main Dec 8, 2020
krisztina-zsihovszki pushed a commit to krisztina-zsihovszki/nifi that referenced this pull request Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants