Skip to content

NIFI-8080: Compile Jython scripts before evaluating#4717

Closed
mattyb149 wants to merge 1 commit intoapache:mainfrom
mattyb149:NIFI-8080
Closed

NIFI-8080: Compile Jython scripts before evaluating#4717
mattyb149 wants to merge 1 commit intoapache:mainfrom
mattyb149:NIFI-8080

Conversation

@mattyb149
Copy link
Contributor

Thank you for submitting a contribution to Apache NiFi.

Please provide a short description of the PR here:

Description of PR

Apply the performance improvement from ScriptedTransformRecord to JythonScriptEngineConfigurator (compile script first).
After running the (currently) ignored added unit test, I noticed up to a 10x performance improvement in ExecuteScript.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on JDK 8?
  • Have you verified that the full build is successful on JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

Copy link
Contributor

@MikeThomsen MikeThomsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM and passes tests.

@asfgit asfgit closed this in 2c0671c Dec 9, 2020
}
}
}
public Object init(ScriptEngine engine, String[] modulePaths) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously, the init() method evaluated the script. Which means that if the script doesn't compile, the processor would be invalid. Now, with the init() method not compiling the script, does that mean that the processor will be valid even if the script is not compilable? Might make sense to compile in the init() method instead of the first iteration of eval?

driesva pushed a commit to driesva/nifi that referenced this pull request Mar 19, 2021
This closes apache#4717

Signed-off-by: Mike Thomsen <mthomsen@apache.org>
krisztina-zsihovszki pushed a commit to krisztina-zsihovszki/nifi that referenced this pull request Jun 28, 2022
This closes apache#4717

Signed-off-by: Mike Thomsen <mthomsen@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants