NIFI-8102 TailFile can skip characters if tailing a file on NFS mount#4736
Closed
adenes wants to merge 2 commits intoapache:mainfrom
Closed
NIFI-8102 TailFile can skip characters if tailing a file on NFS mount#4736adenes wants to merge 2 commits intoapache:mainfrom
adenes wants to merge 2 commits intoapache:mainfrom
Conversation
- Force the TailFile processor to recreate and reposition the reader by setting it to null in case of a NulCharacterEncounteredException - Updated the TestTailFile.testNULContent() to not initialize the processor when calling the second run()
markap14
reviewed
Dec 18, 2020
| session.remove(flowFile); | ||
| tfo.setState(new TailFileState(tailFile, file, reader, position, timestamp, length, checksum, state.getBuffer())); | ||
| // store the new position and set the reader to null to reinitialize and reposition it | ||
| tfo.setState(new TailFileState(tailFile, file, null, positionHolder.get(), timestamp, length, checksum, state.getBuffer())); |
Contributor
There was a problem hiding this comment.
We can't just abandon the existing reader here, as we need to make sure that it gets closed. Otherwise we'd be leaking a file handle. But I don't think we really want to close and abandon the reader we already have anyway. Since we know where we want the reader to be positioned, we should be able to just use reader.position(positionHolder.get()); no?
Contributor
Author
There was a problem hiding this comment.
Thanks @markap14 , agree, updated the pr
Update the reader's position instead of abandoning it.
Contributor
|
Thanks @adenes . Changes look good to me. Will wait for the Github Actions to complete and assuming that all is green there i'll go ahead and merge. |
Contributor
|
Looks like all checked out good, +1 merged to main. Thanks @adenes ! |
driesva
pushed a commit
to driesva/nifi
that referenced
this pull request
Mar 19, 2021
- Force the TailFile processor to recreate and reposition the reader by setting it to null in case of a NulCharacterEncounteredException - Updated the TestTailFile.testNULContent() to not initialize the processor when calling the second run() Update the reader's position instead of abandoning it. This closes apache#4736. Signed-off-by: Mark Payne <markap14@hotmail.com>
krisztina-zsihovszki
pushed a commit
to krisztina-zsihovszki/nifi
that referenced
this pull request
Jun 28, 2022
- Force the TailFile processor to recreate and reposition the reader by setting it to null in case of a NulCharacterEncounteredException - Updated the TestTailFile.testNULContent() to not initialize the processor when calling the second run() Update the reader's position instead of abandoning it. This closes apache#4736. Signed-off-by: Mark Payne <markap14@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
by setting it to null in case of a NulCharacterEncounteredException
processor when calling the second run()
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically
main)?Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not
squashor use--forcewhen pushing to allow for clean monitoring of changes.For code changes:
mvn -Pcontrib-check clean installat the rootnififolder?LICENSEfile, including the mainLICENSEfile undernifi-assembly?NOTICEfile, including the mainNOTICEfile found undernifi-assembly?.displayNamein addition to .name (programmatic access) for each of the new properties?For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.