NIFI-8125 Moved JWT filter ahead of X509 filter#4758
Closed
bbende wants to merge 1 commit intoapache:mainfrom
Closed
NIFI-8125 Moved JWT filter ahead of X509 filter#4758bbende wants to merge 1 commit intoapache:mainfrom
bbende wants to merge 1 commit intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was originally planning to add some type of property to control whether x509 should come before JWT, but it seems as though we should be able to just move JWT in front of it. The only scenario that would change behavior is if you were previously submitting a request to the API with a client cert AND also sending the Authorization header. Previously the Authorization header would be ignored, so arguably should not have been sent anyway.