Skip to content

NIFI-8142 Add "on conflict do nothing" feature to PutDatabaseRecord#4760

Closed
Snorlaxa wants to merge 9 commits intoapache:mainfrom
Snorlaxa:main
Closed

NIFI-8142 Add "on conflict do nothing" feature to PutDatabaseRecord#4760
Snorlaxa wants to merge 9 commits intoapache:mainfrom
Snorlaxa:main

Conversation

@Snorlaxa
Copy link
Contributor

@Snorlaxa Snorlaxa commented Jan 15, 2021

Thank you for submitting a contribution to Apache NiFi.

Please provide a short description of the PR here:

Description of PR

Enables X functionality; fixes bug NIFI-YYYY.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on JDK 8?
  • Have you verified that the full build is successful on JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

@Snorlaxa Snorlaxa changed the title Add "on conflict do nothing" feature to PutDatabaseRecord NIFI-8142 Add "on conflict do nothing" feature to PutDatabaseRecord Jan 15, 2021
Copy link
Contributor

@markap14 markap14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement! I do think this is a valuable feature to add. I do think the separation of this property from the Statement Type property is a bit confusing, though. I think it would make a lot more sense to just have an INSERT_IGNORE statement type, which would also be consistent with the Kudu processors. Also looks like this needs to be rebased.

.expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES)
.build();

static final PropertyDescriptor UPSERT_DO_NOTHING = new PropertyDescriptor.Builder()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels odd to me. A property named "Upsert Do Nothing" I feel is confusing and misleading. It sounds like any upsert should be ignored and not acted upon. And in this case, it's not really upserts that are being ignored, but conflicting Inserts. What makes more sense to me is to add another option for the Statement Type: "INSERT_IGNORE" or something to that effect. This would be consistent with how it is done with PutKudu, also.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your reply and sorry for making that misleading. "INSERT_IGNORE" is a good idea. I will try it later :D

@Snorlaxa Snorlaxa requested a review from markap14 January 22, 2021 03:37
@Snorlaxa
Copy link
Contributor Author

I don't know why my push action cannot trigger any check. Maybe I should close this PR and create another one?

@Snorlaxa Snorlaxa closed this Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants