Skip to content

NIFI-8142 Add "on conflict do nothing" feature to PutDatabaseRecord#4778

Closed
Snorlaxa wants to merge 1 commit intoapache:mainfrom
Snorlaxa:NIFI-8142
Closed

NIFI-8142 Add "on conflict do nothing" feature to PutDatabaseRecord#4778
Snorlaxa wants to merge 1 commit intoapache:mainfrom
Snorlaxa:NIFI-8142

Conversation

@Snorlaxa
Copy link
Contributor

I believe PutDatabaseRecord processor need a feature that we can ignore the record when it already exists in database.

In this implement I add a new Statement Type "INSERT_IGNORE", inspired by @markap14 .

Thank you for submitting a contribution to Apache NiFi.

Please provide a short description of the PR here:

Description of PR

Enables X functionality; fixes bug NIFI-YYYY.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on JDK 8?
  • Have you verified that the full build is successful on JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

@mattyb149
Copy link
Contributor

This PR needs some reorganization, maybe save off the commit(s) where you changed code then reset your branch to match the latest main branch. Then you can put your commits back into the branch (cleaning up any merge conflicts and such). Merging main into your branch usually ends up making things messy.

@mattyb149
Copy link
Contributor

+1 LGTM, ran contrib-check and tried on MySQL, PostgreSQL, and Oracle, all behavior was as expected. However the commit doesn't have the Jira case or description so I will change that before merging, as well as fixing a Checkstyle error. In the future please ensure you run a Maven build (at least for the affected modules) with the -Pcontrib-check profile enabled in order to find any Checkstyle or license issues before posting a Pull Request, that will save time for the reviewers :)

Thanks for the new feature! Merging to main

@mattyb149 mattyb149 closed this in 04fb1ac Jan 27, 2021
driesva pushed a commit to driesva/nifi that referenced this pull request Mar 19, 2021
NIFI-8142: Fix Checkstyle error

Signed-off-by: Matthew Burgess <mattyb149@apache.org>

This closes apache#4778
krisztina-zsihovszki pushed a commit to krisztina-zsihovszki/nifi that referenced this pull request Jun 28, 2022
NIFI-8142: Fix Checkstyle error

Signed-off-by: Matthew Burgess <mattyb149@apache.org>

This closes apache#4778
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants