Skip to content

NIFI-8321 Add NoRouteToHostException#4895

Closed
yapjiahong wants to merge 1 commit intoapache:mainfrom
yapjiahong:httpclient_add_throw_exception
Closed

NIFI-8321 Add NoRouteToHostException#4895
yapjiahong wants to merge 1 commit intoapache:mainfrom
yapjiahong:httpclient_add_throw_exception

Conversation

@yapjiahong
Copy link

@yapjiahong yapjiahong commented Mar 15, 2021

Description of PR

  • Although the HttpClient has thrown an "IOException" and the "StandardRemoteGroupPort", has caught the "IOException"

  • but the HttpClient never throw "NoRouteToHostException",

  • therefore, "StandardRemoteGroupPort" will never catch the exception and still try to create lots of HTTP connections when "NoRouteToHostException" happens

  • "NoRouteToHostException" => when a host/instance suddenly shutdown or remove..., but the RemoteProcessGroup still enable or working.

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on JDK 8?
  • Have you verified that the full build is successful on JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

@github-actions
Copy link

We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be closed. This stale marker and eventual auto close does not indicate a judgement of the PR just lack of reviewer bandwidth and helps us keep the PR queue more manageable. If you would like this PR re-opened you can do so and a committer can remove the stale tag. Or you can open a new PR. Try to help review other PRs to increase PR review bandwidth which in turn helps yours.

@github-actions github-actions bot added the Stale label Jul 25, 2021
@github-actions github-actions bot closed this Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant