NIFI-8329 - Updated dependencies that had no build/test failures when…#4911
NIFI-8329 - Updated dependencies that had no build/test failures when…#4911thenatog wants to merge 3 commits intoapache:mainfrom
Conversation
… updating. NIFI-8329 - Not updating storm dependency in this change, as it is being removed in a separate ticket.
…'jackson-databind.version' pom property in favor of 'jackson.version'
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for the work on this @thenatog! Verified successful build and basic runtime behavior. Reviewed change logs for Jackson and several other dependencies, no concerning issues noted. See the one comment on the Jackson version of nifi-azure, otherwise looks good.
| <azure-storage.version>8.4.0</azure-storage.version> | ||
| <azure.core.version>1.6.0</azure.core.version> | ||
| <jackson.version>2.10.3</jackson.version> | ||
| <jackson.version>2.12.2</jackson.version> |
There was a problem hiding this comment.
Is there a reason for retaining this property in the nifi-azure-bundle or could it be removed so that the bundle relies on the property value of the root Maven configuration?
There was a problem hiding this comment.
I thought I had issues with the property being picked up from this module, but I tested it again and it seems fine. Removed this with a new commit.
There was a problem hiding this comment.
Thanks for confirming and making the change.
…use the global property instead.
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks again @thenatog! +1 Merging.
NIFI-8329 - Removed unnecessary jackson.version from azure bundle to use the global property instead. NIFI-8329 - Updated jackson/jackson-databind version and removed the 'jackson-databind.version' pom property in favor of 'jackson.version' Updated dependencies include the following: - jackson-core - jackson-databind - icu4j - snakeyaml - spring-integration-mail - spring-core and framework modules - activemq-client - activemq-broker - xercesImpl This closes apache#4911 Signed-off-by: David Handermann <exceptionfactory@apache.org>
… updating.
NIFI-8329 - Not updating storm dependency in this change, as it is being removed in a separate ticket.
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Enables X functionality; fixes bug NIFI-YYYY.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically
main)?Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not
squashor use--forcewhen pushing to allow for clean monitoring of changes.For code changes:
mvn -Pcontrib-check clean installat the rootnififolder?LICENSEfile, including the mainLICENSEfile undernifi-assembly?NOTICEfile, including the mainNOTICEfile found undernifi-assembly?.displayNamein addition to .name (programmatic access) for each of the new properties?For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.