Skip to content

NIFI-8373 Add Kerberos support to Accumulo processors#4973

Closed
timeabarna wants to merge 5 commits intoapache:mainfrom
timeabarna:NIFI-8373
Closed

NIFI-8373 Add Kerberos support to Accumulo processors#4973
timeabarna wants to merge 5 commits intoapache:mainfrom
timeabarna:NIFI-8373

Conversation

@timeabarna
Copy link
Contributor

@timeabarna timeabarna commented Apr 6, 2021

Add Kerberos support to Accumulo processors

https://issues.apache.org/jira/browse/NIFI-8373

Description of PR

Add Kerberos support to Accumulo processors

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on JDK 8?
  • Have you verified that the full build is successful on JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

Copy link
Member

@joshelser joshelser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bbende asked me to take a look. A few thoughts.

@timeabarna
Copy link
Contributor Author

@joshelser @bbende Josh and Bryan thank you very much for your help, PR has been updated

@pvillard31
Copy link
Contributor

@joshelser @bbende - does it look good to you?

@bbende
Copy link
Contributor

bbende commented Apr 20, 2021

@pvillard31 I don't really see any issues, but I don't currently have time to try it out

@phrocker
Copy link
Contributor

phrocker commented Apr 21, 2021

@pvillard31 I will try and find some time to get this tested. The code looks good, so I will see if I can spin an instance up to run this. thanks

@timeabarna timeabarna force-pushed the NIFI-8373 branch 2 times, most recently from aa0048a to e542647 Compare May 3, 2021 11:37
@phrocker
Copy link
Contributor

phrocker commented May 10, 2021

@timeabarna I saw some changes within the last few days. Is this okay to test or are there additional changes coming down the pipeline? I am hoping to find some additional time to test this week -- It seemed okay when I tried it the week before last but wanted to try to find some time to test with the additional changes.

@timeabarna
Copy link
Contributor Author

@phrocker All the planned changes are up, you can test it. Thanks in advance for your help.

@timeabarna timeabarna force-pushed the NIFI-8373 branch 4 times, most recently from c0693af to 3583e2a Compare May 20, 2021 13:30
@asfgit asfgit closed this in b6f8441 May 21, 2021
@tpalfy
Copy link
Contributor

tpalfy commented May 21, 2021

LGTM+1

Merged to main.

@phrocker
Copy link
Contributor

phrocker commented May 21, 2021

@timeabarna Sorry I meant to reply to say that all was good with testing. I lost track of time, but after seeing @tpalfy 's merge, I am happy to add that I didn't encounter issues during testing. Thanks!

I was able to set aside a few hours late last Friday and simply forgot to respond. My apologies for being scatter-brained.

@timeabarna
Copy link
Contributor Author

@phrocker No worries. Thank you very much for your help. Your feedback and time are much appreciated.

krisztina-zsihovszki pushed a commit to krisztina-zsihovszki/nifi that referenced this pull request Jun 28, 2022
This closes apache#4973.

Signed-off-by: Tamas Palfy <tamas.bertalan.palfy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants