NIFI-8373 Add Kerberos support to Accumulo processors#4973
NIFI-8373 Add Kerberos support to Accumulo processors#4973timeabarna wants to merge 5 commits intoapache:mainfrom
Conversation
...mulo-services/src/main/java/org/apache/nifi/accumulo/controllerservices/AccumuloService.java
Show resolved
Hide resolved
...mulo-services/src/main/java/org/apache/nifi/accumulo/controllerservices/AccumuloService.java
Outdated
Show resolved
Hide resolved
...mulo-services/src/main/java/org/apache/nifi/accumulo/controllerservices/AccumuloService.java
Outdated
Show resolved
Hide resolved
...mulo-services/src/main/java/org/apache/nifi/accumulo/controllerservices/AccumuloService.java
Outdated
Show resolved
Hide resolved
...mulo-services/src/main/java/org/apache/nifi/accumulo/controllerservices/AccumuloService.java
Outdated
Show resolved
Hide resolved
|
@joshelser @bbende Josh and Bryan thank you very much for your help, PR has been updated |
|
@joshelser @bbende - does it look good to you? |
...mulo-services/src/main/java/org/apache/nifi/accumulo/controllerservices/AccumuloService.java
Outdated
Show resolved
Hide resolved
|
@pvillard31 I don't really see any issues, but I don't currently have time to try it out |
|
@pvillard31 I will try and find some time to get this tested. The code looks good, so I will see if I can spin an instance up to run this. thanks |
...mulo-services/src/main/java/org/apache/nifi/accumulo/controllerservices/AccumuloService.java
Outdated
Show resolved
Hide resolved
...mulo-services/src/main/java/org/apache/nifi/accumulo/controllerservices/AccumuloService.java
Outdated
Show resolved
Hide resolved
...mulo-services/src/main/java/org/apache/nifi/accumulo/controllerservices/AccumuloService.java
Outdated
Show resolved
Hide resolved
...mulo-services/src/main/java/org/apache/nifi/accumulo/controllerservices/AccumuloService.java
Show resolved
Hide resolved
...mulo-services/src/main/java/org/apache/nifi/accumulo/controllerservices/AccumuloService.java
Outdated
Show resolved
Hide resolved
...mulo-services/src/main/java/org/apache/nifi/accumulo/controllerservices/AccumuloService.java
Outdated
Show resolved
Hide resolved
...mulo-services/src/main/java/org/apache/nifi/accumulo/controllerservices/AccumuloService.java
Outdated
Show resolved
Hide resolved
...mulo-services/src/main/java/org/apache/nifi/accumulo/controllerservices/AccumuloService.java
Show resolved
Hide resolved
...mulo-services/src/main/java/org/apache/nifi/accumulo/controllerservices/AccumuloService.java
Outdated
Show resolved
Hide resolved
...mulo-services/src/main/java/org/apache/nifi/accumulo/controllerservices/AccumuloService.java
Outdated
Show resolved
Hide resolved
...mulo-services/src/main/java/org/apache/nifi/accumulo/controllerservices/AccumuloService.java
Outdated
Show resolved
Hide resolved
...mulo-services/src/main/java/org/apache/nifi/accumulo/controllerservices/AccumuloService.java
Outdated
Show resolved
Hide resolved
...mulo-services/src/main/java/org/apache/nifi/accumulo/controllerservices/AccumuloService.java
Outdated
Show resolved
Hide resolved
...mulo-services/src/main/java/org/apache/nifi/accumulo/controllerservices/AccumuloService.java
Show resolved
Hide resolved
...mulo-services/src/main/java/org/apache/nifi/accumulo/controllerservices/AccumuloService.java
Outdated
Show resolved
Hide resolved
...mulo-services/src/main/java/org/apache/nifi/accumulo/controllerservices/AccumuloService.java
Outdated
Show resolved
Hide resolved
...mulo-services/src/main/java/org/apache/nifi/accumulo/controllerservices/AccumuloService.java
Outdated
Show resolved
Hide resolved
aa0048a to
e542647
Compare
|
@timeabarna I saw some changes within the last few days. Is this okay to test or are there additional changes coming down the pipeline? I am hoping to find some additional time to test this week -- It seemed okay when I tried it the week before last but wanted to try to find some time to test with the additional changes. |
|
@phrocker All the planned changes are up, you can test it. Thanks in advance for your help. |
c0693af to
3583e2a
Compare
|
LGTM+1 Merged to main. |
|
@timeabarna Sorry I meant to reply to say that all was good with testing. I lost track of time, but after seeing @tpalfy 's merge, I am happy to add that I didn't encounter issues during testing. Thanks! I was able to set aside a few hours late last Friday and simply forgot to respond. My apologies for being scatter-brained. |
|
@phrocker No worries. Thank you very much for your help. Your feedback and time are much appreciated. |
This closes apache#4973. Signed-off-by: Tamas Palfy <tamas.bertalan.palfy@gmail.com>
Add Kerberos support to Accumulo processors
https://issues.apache.org/jira/browse/NIFI-8373
Description of PR
Add Kerberos support to Accumulo processors
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically
main)?Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not
squashor use--forcewhen pushing to allow for clean monitoring of changes.For code changes:
mvn -Pcontrib-check clean installat the rootnififolder?LICENSEfile, including the mainLICENSEfile undernifi-assembly?NOTICEfile, including the mainNOTICEfile found undernifi-assembly?.displayNamein addition to .name (programmatic access) for each of the new properties?For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.