Skip to content

NIFI-3862: Added Issuer DN support to ListenHTTP#4976

Closed
gresockj wants to merge 1 commit intoapache:mainfrom
gresockj:NIFI-3862
Closed

NIFI-3862: Added Issuer DN support to ListenHTTP#4976
gresockj wants to merge 1 commit intoapache:mainfrom
gresockj:NIFI-3862

Conversation

@gresockj
Copy link
Contributor

@gresockj gresockj commented Apr 6, 2021

Description of PR

Beyond just adding the restlistener.remote.issuer.dn attribute to flow files coming out of the ListenHTTP processor, this patch adds an optional "Authorized Issuer DN Pattern" property to ListenHTTP, which will allow finer-grained authorization of users.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on JDK 8?
  • Have you verified that the full build is successful on JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @gresockj! The implementation looks good, just a couple very minor comments on logging and documentation. Given the existing number of unit test methods for ListenHTTP, it would be worth considering whether the two methods testing successful responses are necessary.

Copy link
Contributor

@turcsanyip turcsanyip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gresockj Thank you for adding this new property to ListenHTTP!
I tested it with different setups and it works properly.

I added some comments regarding the names / displayNames of the properties.
Otherwise, the code looks fine.

Copy link
Contributor

@turcsanyip turcsanyip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gresockj Thanks for the changes!

+1 LGTM
Merging.

@asfgit asfgit closed this in be716c1 Apr 20, 2021
krisztina-zsihovszki pushed a commit to krisztina-zsihovszki/nifi that referenced this pull request Jun 28, 2022
This closes apache#4976.

Signed-off-by: Peter Turcsanyi <turcsanyi@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants