NIFI-3862: Added Issuer DN support to ListenHTTP#4976
Closed
gresockj wants to merge 1 commit intoapache:mainfrom
Closed
NIFI-3862: Added Issuer DN support to ListenHTTP#4976gresockj wants to merge 1 commit intoapache:mainfrom
gresockj wants to merge 1 commit intoapache:mainfrom
Conversation
Contributor
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for the contribution @gresockj! The implementation looks good, just a couple very minor comments on logging and documentation. Given the existing number of unit test methods for ListenHTTP, it would be worth considering whether the two methods testing successful responses are necessary.
...processors/src/main/java/org/apache/nifi/processors/standard/servlets/ListenHTTPServlet.java
Outdated
Show resolved
Hide resolved
...processors/src/main/java/org/apache/nifi/processors/standard/servlets/ListenHTTPServlet.java
Outdated
Show resolved
Hide resolved
...processors/src/main/java/org/apache/nifi/processors/standard/servlets/ListenHTTPServlet.java
Outdated
Show resolved
Hide resolved
...e/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListenHTTP.java
Outdated
Show resolved
Hide resolved
...fi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestListenHTTP.java
Show resolved
Hide resolved
...fi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestListenHTTP.java
Outdated
Show resolved
Hide resolved
turcsanyip
requested changes
Apr 19, 2021
Contributor
turcsanyip
left a comment
There was a problem hiding this comment.
@gresockj Thank you for adding this new property to ListenHTTP!
I tested it with different setups and it works properly.
I added some comments regarding the names / displayNames of the properties.
Otherwise, the code looks fine.
...e/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListenHTTP.java
Show resolved
Hide resolved
...e/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListenHTTP.java
Outdated
Show resolved
Hide resolved
turcsanyip
approved these changes
Apr 20, 2021
Contributor
turcsanyip
left a comment
There was a problem hiding this comment.
@gresockj Thanks for the changes!
+1 LGTM
Merging.
krisztina-zsihovszki
pushed a commit
to krisztina-zsihovszki/nifi
that referenced
this pull request
Jun 28, 2022
This closes apache#4976. Signed-off-by: Peter Turcsanyi <turcsanyi@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Beyond just adding the restlistener.remote.issuer.dn attribute to flow files coming out of the ListenHTTP processor, this patch adds an optional "Authorized Issuer DN Pattern" property to ListenHTTP, which will allow finer-grained authorization of users.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically
main)?Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not
squashor use--forcewhen pushing to allow for clean monitoring of changes.For code changes:
mvn -Pcontrib-check clean installat the rootnififolder?LICENSEfile, including the mainLICENSEfile undernifi-assembly?NOTICEfile, including the mainNOTICEfile found undernifi-assembly?.displayNamein addition to .name (programmatic access) for each of the new properties?For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.