Skip to content

NIFI-8470#5026

Closed
tolaini wants to merge 1 commit into
apache:support/nifi-1.13from
tolaini:tech
Closed

NIFI-8470#5026
tolaini wants to merge 1 commit into
apache:support/nifi-1.13from
tolaini:tech

Conversation

@tolaini
Copy link
Copy Markdown
Contributor

@tolaini tolaini commented Apr 24, 2021

Description of PR

Fixes bug NIFI-8470.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on JDK 8?
  • Have you verified that the full build is successful on JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

Avoid truncating strings when inserting into CHAR columns
@tolaini tolaini changed the base branch from main to support/nifi-1.13 April 24, 2021 14:41
@markap14
Copy link
Copy Markdown
Contributor

Hey @tolaini the change looks good to me, but the base branch needs to be main, not support/nifi-1.13. Can you change that? If we do end up doing another 1.13.x release, it can get pulled over then as apart of that release process.

@tolaini
Copy link
Copy Markdown
Contributor Author

tolaini commented Apr 24, 2021

Hey @tolaini the change looks good to me, but the base branch needs to be main, not support/nifi-1.13. Can you change that? If we do end up doing another 1.13.x release, it can get pulled over then as apart of that release process.

Hi, I have created PR #5027 rebased to main.

@mattyb149 mattyb149 closed this May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants