Skip to content

NIFI-8506 Fix Azure Storage integrated tests.#5047

Closed
gschaer wants to merge 2 commits intoapache:mainfrom
gschaer:nifi-8506
Closed

NIFI-8506 Fix Azure Storage integrated tests.#5047
gschaer wants to merge 2 commits intoapache:mainfrom
gschaer:nifi-8506

Conversation

@gschaer
Copy link
Copy Markdown
Contributor

@gschaer gschaer commented May 2, 2021

Thank you for submitting a contribution to Apache NiFi.

Please provide a short description of the PR here:

Description of PR

Fixes bug NIFI-8506.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on JDK 8?
  • Have you verified that the full build is successful on JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

@jfrazee jfrazee self-requested a review May 3, 2021 03:31
Copy link
Copy Markdown
Member

@jfrazee jfrazee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gschaer Thanks for this.

Since you've removed the @Ignore it's now failing the check style because it's an unused import. Can you remove the import?

@gschaer
Copy link
Copy Markdown
Contributor Author

gschaer commented May 3, 2021

Since you've removed the @Ignore it's now failing the check style because it's an unused import. Can you remove the import?

@jfrazee I missed that one, my bad. This should work now.

@gschaer gschaer requested a review from jfrazee May 3, 2021 08:56
Copy link
Copy Markdown
Member

@jfrazee jfrazee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran the integrations for these, everything passes, and with the large file tests these run ~ 90 seconds, so I think we're good.

mvn integration-test -Dtest='**/IT*BlobStorage' -ff -nsu
mvn integration-test -Dtest='**/IT*DataLakeStorage' -ff -nsu

+1

@jfrazee jfrazee closed this in 24d3d43 May 3, 2021
@gschaer gschaer deleted the nifi-8506 branch May 4, 2021 10:15
krisztina-zsihovszki pushed a commit to krisztina-zsihovszki/nifi that referenced this pull request Jun 28, 2022
This closes apache#5047

Signed-off-by: Joey Frazee <jfrazee@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants