NIFI-8520 - Parameter Contexts - Show the wrong information of referencing compon…

[s9514171]

…ents

the selected row of parametersGrid doesn't unset when close the parameter dialog

when we close then open the parameter dialog, the parameterData.addItem(parameter); will fire the onSelectedRowsChanged to show a wrong information

Description of PR

https://issues.apache.org/jira/browse/NIFI-8520

For all changes:

• Is there a JIRA ticket associated with this PR? Is it referenced
  in the commit message?

• Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

• Has your PR been rebased against the latest commit within the target branch (typically main)?

• Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

• Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
• Have you written or updated unit tests to verify your changes?
• Have you verified that the full build is successful on JDK 8?
• Have you verified that the full build is successful on JDK 11?
• If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
• If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
• If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
• If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

• Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

[pvillard31]

This is fixing the issue I raised in #5048. Thanks @s9514171
Will leave this open for a few days in case @mcgilman @moranr @scottyaslan want to confirm as well.

[scottyaslan]

reviewing...

[scottyaslan]

I have tested this and it works as advertised.... but I can't figure out why this works or what the original issue is...

[scottyaslan]

By not resetting this count each time the parameter context table is displayed the count now grows each time the dialog is opened.

[s9514171]

@scottyaslan sorry for the late reply, the first fix idea is referenced from variable handling..., but it seems to have the potential issue as you mentioned. maybe we can also fix it too.
I'm reviewing it again, and currently, I find there is a better way to solve it. I'll update later after testing

[s9514171]

@scottyaslan I have force-push a new commit for this issue.

This commit unset the rows when calling the resetDialog

if we do not unset it,
when we close then open the parameter dialog, the parameterData.addItem(parameter); will fire the onSelectedRowsChanged to show a wrong information

Thanks

[s9514171]

CI failed, but seems not related to the PR

[scottyaslan]

Thanks @s9514171 I am a +1!

[s9514171]

Thanks @scottyaslan. I also open another JIRA #5097 for the issue variable count not reset in variable registry dialog.