Skip to content

NIFI-8725 Added Single User Environment Variables for Docker#5178

Merged
markap14 merged 2 commits intoapache:mainfrom
exceptionfactory:NIFI-8725
Jun 23, 2021
Merged

NIFI-8725 Added Single User Environment Variables for Docker#5178
markap14 merged 2 commits intoapache:mainfrom
exceptionfactory:NIFI-8725

Conversation

@exceptionfactory
Copy link
Contributor

Description of PR

NIFI-8725 Adds support for specifying Single User authentication credentials using environment variables in NiFi Docker images. Additional updates include an example command and links to the Administration Guide section in the Docker README.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on JDK 8?
  • Have you verified that the full build is successful on JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

- Updated Docker README.md with example command and link to Administration Guide section
- Updated Docker integration test to check HTTP response status
@markap14 markap14 merged commit 1d9ea6d into apache:main Jun 23, 2021
@markap14
Copy link
Contributor

Thanks @exceptionfactory was able to verify changes work exactly as expected. Makes it a lot easier to run this in docker! +1 merged to main.

timeabarna pushed a commit to timeabarna/nifi that referenced this pull request Jul 6, 2021
…5178)

* NIFI-8725 Added Single User Environment Variables for Docker

- Updated Docker README.md with example command and link to Administration Guide section
- Updated Docker integration test to check HTTP response status
- Disabled integration test plugin for dockerhub because it depends on changes on the main branch. Can be re-enabled after 1.14.0 is released.
timeabarna pushed a commit to timeabarna/nifi that referenced this pull request Jul 21, 2021
…5178)

* NIFI-8725 Added Single User Environment Variables for Docker

- Updated Docker README.md with example command and link to Administration Guide section
- Updated Docker integration test to check HTTP response status
- Disabled integration test plugin for dockerhub because it depends on changes on the main branch. Can be re-enabled after 1.14.0 is released.
krisztina-zsihovszki pushed a commit to krisztina-zsihovszki/nifi that referenced this pull request Jun 28, 2022
…5178)

* NIFI-8725 Added Single User Environment Variables for Docker

- Updated Docker README.md with example command and link to Administration Guide section
- Updated Docker integration test to check HTTP response status
- Disabled integration test plugin for dockerhub because it depends on changes on the main branch. Can be re-enabled after 1.14.0 is released.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants