Skip to content

NIFI-8630 Upgraded javax.mail 1.4.7 to jakarta.mail 2.0.1 for PutEmail#5179

Closed
exceptionfactory wants to merge 2 commits intoapache:mainfrom
exceptionfactory:NIFI-8630
Closed

NIFI-8630 Upgraded javax.mail 1.4.7 to jakarta.mail 2.0.1 for PutEmail#5179
exceptionfactory wants to merge 2 commits intoapache:mainfrom
exceptionfactory:NIFI-8630

Conversation

@exceptionfactory
Copy link
Contributor

Description of PR

NIFI-8630 Upgrades javax.mail 1.4.7 to jakarta.mail 2.0.1 to support modern TLS protocol versions in the PutEmail processor.

Older versions of javax.mail do not support TLSv1.2, causing SSLHandshakeException errors in PutEmail when running on Java versions that have disabled TLSv1 and TLSv1.1. The jakarta.mail library is the maintained and repackaged version of the javax.mail library, which supports current TLS protocol versions matching JDK enabled protocols. Upgrading to Jakarta Mail also required including the updated Jarkata Activation library.

Additional updates include a display name of SMTP STARTTLS for the SMTP TLS property, indicating that it is used to enable Opportunistic TLS over SMTP.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on JDK 8?
  • Have you verified that the full build is successful on JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

- Added jakarata.activation 2.0.1 to support jakarta.mail 2.0.1
- Clarified description of SMTP TLS property enabling STARTTLS
@pvillard31
Copy link
Contributor

@exceptionfactory
Copy link
Contributor Author

Do we know if this also solves https://issues.apache.org/jira/browse/NIFI-8281 ?
(and maybe https://issues.apache.org/jira/browse/NIFI-6961)

Thanks for referencing those issues @pvillard31. This PR should resolve NIFI-8281 since it includes the new version of Jakarta Activation. The dependency changes include both the Jakarta Activation API as well as the Jakarta Activation implementation library.

NIFI-6961 references the ExtractEmailHeaders processor, which is in a different NAR bundle, so a separate PR will be necessary to address dependencies in that processor. Upgrading dependencies in that bundle will be more challenging due to transitive dependencies on javax.mail from several libraries, but making a similar change is necessary.

I updated both of those Jira issues with links to NIFI-8630.

Copy link
Contributor

@gresockj gresockj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any substantive issues with the changes, just a few minor style suggestions for the existing code. Planning to verify runtime behavior next.

Copy link
Contributor

@gresockj gresockj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using ListenSMTP over TLSv1.2 and TLSv1.3, I verified that PutEmail now works with these protocols. Nice work!

@asfgit asfgit closed this in 786f171 Jun 25, 2021
timeabarna pushed a commit to timeabarna/nifi that referenced this pull request Jul 6, 2021
- Added jakarata.activation 2.0.1 to support jakarta.mail 2.0.1
- Clarified description of SMTP TLS property enabling STARTTLS

NIFI-8630 Added final to several variables and adjusted variable declaration

Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com>

This closes apache#5179.
timeabarna pushed a commit to timeabarna/nifi that referenced this pull request Jul 21, 2021
- Added jakarata.activation 2.0.1 to support jakarta.mail 2.0.1
- Clarified description of SMTP TLS property enabling STARTTLS

NIFI-8630 Added final to several variables and adjusted variable declaration

Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com>

This closes apache#5179.
krisztina-zsihovszki pushed a commit to krisztina-zsihovszki/nifi that referenced this pull request Jun 28, 2022
- Added jakarata.activation 2.0.1 to support jakarta.mail 2.0.1
- Clarified description of SMTP TLS property enabling STARTTLS

NIFI-8630 Added final to several variables and adjusted variable declaration

Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com>

This closes apache#5179.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants