NIFI-8630 Upgraded javax.mail 1.4.7 to jakarta.mail 2.0.1 for PutEmail#5179
NIFI-8630 Upgraded javax.mail 1.4.7 to jakarta.mail 2.0.1 for PutEmail#5179exceptionfactory wants to merge 2 commits intoapache:mainfrom
Conversation
- Added jakarata.activation 2.0.1 to support jakarta.mail 2.0.1 - Clarified description of SMTP TLS property enabling STARTTLS
|
Do we know if this also solves https://issues.apache.org/jira/browse/NIFI-8281 ? |
Thanks for referencing those issues @pvillard31. This PR should resolve NIFI-8281 since it includes the new version of Jakarta Activation. The dependency changes include both the Jakarta Activation API as well as the Jakarta Activation implementation library. NIFI-6961 references the I updated both of those Jira issues with links to NIFI-8630. |
gresockj
left a comment
There was a problem hiding this comment.
I don't see any substantive issues with the changes, just a few minor style suggestions for the existing code. Planning to verify runtime behavior next.
...dle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutEmail.java
Outdated
Show resolved
Hide resolved
...dle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutEmail.java
Outdated
Show resolved
Hide resolved
bec3b3f to
04e75f1
Compare
gresockj
left a comment
There was a problem hiding this comment.
Using ListenSMTP over TLSv1.2 and TLSv1.3, I verified that PutEmail now works with these protocols. Nice work!
- Added jakarata.activation 2.0.1 to support jakarta.mail 2.0.1 - Clarified description of SMTP TLS property enabling STARTTLS NIFI-8630 Added final to several variables and adjusted variable declaration Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com> This closes apache#5179.
- Added jakarata.activation 2.0.1 to support jakarta.mail 2.0.1 - Clarified description of SMTP TLS property enabling STARTTLS NIFI-8630 Added final to several variables and adjusted variable declaration Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com> This closes apache#5179.
- Added jakarata.activation 2.0.1 to support jakarta.mail 2.0.1 - Clarified description of SMTP TLS property enabling STARTTLS NIFI-8630 Added final to several variables and adjusted variable declaration Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com> This closes apache#5179.
Description of PR
NIFI-8630 Upgrades
javax.mail1.4.7 tojakarta.mail2.0.1 to support modern TLS protocol versions in thePutEmailprocessor.Older versions of javax.mail do not support TLSv1.2, causing
SSLHandshakeExceptionerrors inPutEmailwhen running on Java versions that have disabled TLSv1 and TLSv1.1. Thejakarta.maillibrary is the maintained and repackaged version of thejavax.maillibrary, which supports current TLS protocol versions matching JDK enabled protocols. Upgrading to Jakarta Mail also required including the updated Jarkata Activation library.Additional updates include a display name of
SMTP STARTTLSfor theSMTP TLSproperty, indicating that it is used to enable Opportunistic TLS over SMTP.In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically
main)?Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not
squashor use--forcewhen pushing to allow for clean monitoring of changes.For code changes:
mvn -Pcontrib-check clean installat the rootnififolder?LICENSEfile, including the mainLICENSEfile undernifi-assembly?NOTICEfile, including the mainNOTICEfile found undernifi-assembly?.displayNamein addition to .name (programmatic access) for each of the new properties?For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.