Skip to content

NIFI-8931 Remove OTP Authentication#5235

Closed
exceptionfactory wants to merge 1 commit intoapache:mainfrom
exceptionfactory:NIFI-8931
Closed

NIFI-8931 Remove OTP Authentication#5235
exceptionfactory wants to merge 1 commit intoapache:mainfrom
exceptionfactory:NIFI-8931

Conversation

@exceptionfactory
Copy link
Contributor

Description of PR

NIFI-8931 Removes One-time Password authentication and associated token REST resources.

Transitioning to HTTP session cookies for passing JSON Web Tokens in #4988 eliminated the need for OTP authentication when downloading files or launching user interface extensions. Web browsers include HTTP session cookies on requests, which removes the requirement for JavaScript calls to request an access token prior to making requests.

Changes include removal of the OTP authentication services as well as the download-token and ui-extension-token REST Access Resources, along with the associated JavaScript code.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on JDK 8?
  • Have you verified that the full build is successful on JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

- Removed download-token and ui-extension-token REST resources
- Removed getAccessToken functions from JavaScript components
Copy link
Contributor

@gresockj gresockj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that this still works with and without OIDC login. Tested downloading from the provenance screen and using a custom UI like JoltTransformJSON. Nice work cleaning up this portion of the code, @exceptionfactory!

@thenatog
Copy link
Contributor

Tested this out with X509 and LDAP, was able to download flow file content, and view in the content browser. I was also able to download template files. Big chunk of code gone, awesome.
+1 wil merge.

@exceptionfactory
Copy link
Contributor Author

Thanks for the review @thenatog!

@thenatog thenatog closed this in 0ba9f0d Jul 22, 2021
krisztina-zsihovszki pushed a commit to krisztina-zsihovszki/nifi that referenced this pull request Jun 28, 2022
- Removed download-token and ui-extension-token REST resources
- Removed getAccessToken functions from JavaScript components

Signed-off-by: Nathan Gough <thenatog@gmail.com>

This closes apache#5235.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants