NIFI-8449: Support transactional batch operations to PutAzureCosmosDBRecord#5241
NIFI-8449: Support transactional batch operations to PutAzureCosmosDBRecord#5241sjyang18 wants to merge 2 commits intoapache:mainfrom
Conversation
jfrazee
left a comment
There was a problem hiding this comment.
@sjyang18 Thanks for these changes. Overall it looks good. Other than stuff like how the log messages are handled and finals I think there are a few things to look at:
- I think the various inserts could be simplified. We have
insertWithTransactionalBatch(),insertRecord(),chooseInsertMethodAndRun(), andbulkInsert(). I think it gets a little confusing. I thinkinsertRecord()andinsertWithTransactionalBatch()could be combined if there were a branch withif (records.size() == 1). - We need to handle more error cases. In particular 413 (Entity too large).
- I don't totally understand the yield handling in
onTrigger(). Can you explain that a little more?
...ssors/src/main/java/org/apache/nifi/processors/azure/cosmos/document/AzureCosmosDBUtils.java
Show resolved
Hide resolved
...s/src/main/java/org/apache/nifi/processors/azure/cosmos/document/PutAzureCosmosDBRecord.java
Outdated
Show resolved
Hide resolved
...s/src/main/java/org/apache/nifi/processors/azure/cosmos/document/PutAzureCosmosDBRecord.java
Outdated
Show resolved
Hide resolved
...s/src/main/java/org/apache/nifi/processors/azure/cosmos/document/PutAzureCosmosDBRecord.java
Outdated
Show resolved
Hide resolved
...s/src/main/java/org/apache/nifi/processors/azure/cosmos/document/PutAzureCosmosDBRecord.java
Outdated
Show resolved
Hide resolved
...s/src/main/java/org/apache/nifi/processors/azure/cosmos/document/PutAzureCosmosDBRecord.java
Outdated
Show resolved
Hide resolved
...s/src/main/java/org/apache/nifi/processors/azure/cosmos/document/PutAzureCosmosDBRecord.java
Outdated
Show resolved
Hide resolved
...s/src/main/java/org/apache/nifi/processors/azure/cosmos/document/PutAzureCosmosDBRecord.java
Outdated
Show resolved
Hide resolved
...s/src/main/java/org/apache/nifi/processors/azure/cosmos/document/PutAzureCosmosDBRecord.java
Outdated
Show resolved
Hide resolved
...s/src/main/java/org/apache/nifi/processors/azure/cosmos/document/PutAzureCosmosDBRecord.java
Show resolved
Hide resolved
To me, yield handing, thus putting the current flowfile into the queue for retry, seems to make sense when server-side throttling is happening and server-side RU change is in progress. For other errors, I output the flowfile to failure relationship. |
|
We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be closed. This stale marker and eventual auto close does not indicate a judgement of the PR just lack of reviewer bandwidth and helps us keep the PR queue more manageable. If you would like this PR re-opened you can do so and a committer can remove the stale tag. Or you can open a new PR. Try to help review other PRs to increase PR review bandwidth which in turn helps yours. |
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Add support for transactional batch operations to PutAzureCosmosDBRecord + fixes bug reported in NIFI-8652
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically
main)?Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not
squashor use--forcewhen pushing to allow for clean monitoring of changes.For code changes:
mvn -Pcontrib-check clean installat the rootnififolder?LICENSEfile, including the mainLICENSEfile undernifi-assembly?NOTICEfile, including the mainNOTICEfile found undernifi-assembly?.displayNamein addition to .name (programmatic access) for each of the new properties?For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.