Skip to content

NIFI-8449: Support transactional batch operations to PutAzureCosmosDBRecord#5241

Closed
sjyang18 wants to merge 2 commits intoapache:mainfrom
sjyang18:NIFI-8449
Closed

NIFI-8449: Support transactional batch operations to PutAzureCosmosDBRecord#5241
sjyang18 wants to merge 2 commits intoapache:mainfrom
sjyang18:NIFI-8449

Conversation

@sjyang18
Copy link
Contributor

Thank you for submitting a contribution to Apache NiFi.

Please provide a short description of the PR here:

Description of PR

Add support for transactional batch operations to PutAzureCosmosDBRecord + fixes bug reported in NIFI-8652

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on JDK 8?
  • Have you verified that the full build is successful on JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

@jfrazee jfrazee self-requested a review July 26, 2021 16:54
Copy link
Member

@jfrazee jfrazee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sjyang18 Thanks for these changes. Overall it looks good. Other than stuff like how the log messages are handled and finals I think there are a few things to look at:

  • I think the various inserts could be simplified. We have insertWithTransactionalBatch(), insertRecord(), chooseInsertMethodAndRun(), and bulkInsert(). I think it gets a little confusing. I think insertRecord() and insertWithTransactionalBatch() could be combined if there were a branch with if (records.size() == 1).
  • We need to handle more error cases. In particular 413 (Entity too large).
  • I don't totally understand the yield handling in onTrigger(). Can you explain that a little more?

@sjyang18
Copy link
Contributor Author

sjyang18 commented Sep 8, 2021

@sjyang18 Thanks for these changes. Overall it looks good. Other than stuff like how the log messages are handled and finals I think there are a few things to look at:

  • I think the various inserts could be simplified. We have insertWithTransactionalBatch(), insertRecord(), chooseInsertMethodAndRun(), and bulkInsert(). I think it gets a little confusing. I think insertRecord() and insertWithTransactionalBatch() could be combined if there were a branch with if (records.size() == 1).
  • We need to handle more error cases. In particular 413 (Entity too large).
  • I don't totally understand the yield handling in onTrigger(). Can you explain that a little more?

To me, yield handing, thus putting the current flowfile into the queue for retry, seems to make sense when server-side throttling is happening and server-side RU change is in progress. For other errors, I output the flowfile to failure relationship.

@github-actions
Copy link

github-actions bot commented Jan 7, 2022

We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be closed. This stale marker and eventual auto close does not indicate a judgement of the PR just lack of reviewer bandwidth and helps us keep the PR queue more manageable. If you would like this PR re-opened you can do so and a committer can remove the stale tag. Or you can open a new PR. Try to help review other PRs to increase PR review bandwidth which in turn helps yours.

@github-actions github-actions bot added the Stale label Jan 7, 2022
@github-actions github-actions bot closed this Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants