NIFI-8964 Add Cluster Firewall Configuration to Admin Guide#5264
NIFI-8964 Add Cluster Firewall Configuration to Admin Guide#5264markap14 merged 2 commits intoapache:mainfrom
Conversation
| heartbeats and connection requests from potential cluster members. | ||
|
|
||
| The configuration file format expects one entry per line and ignores lines beginning with the `#` character. NiFi uses | ||
| standard hostname resolution to convert names to IP addresses. The configuration file supports IPv4 addresses or subnet |
There was a problem hiding this comment.
Could you add more info on what "standard hostname resolution" means? For example, I believe NiFi has no inherent ability to resolve an IP address. This capability relies on that of the host.
There was a problem hiding this comment.
What do you think about changing it to read as follows?
NiFi uses standard Java host name resolution to convert names to IP addresses. Java host name resolution leverages a combination of local machine configuration and network services, such as DNS.
There was a problem hiding this comment.
Yes, that looks good. Thanks.
There was a problem hiding this comment.
Thanks, I appreciate the feedback!
| 192.168.0.2 | ||
| 192.168.0.3 | ||
| # Cluster Subnet Address | ||
| 192.168.0.0/29 # Address Range from 192.168.0.1 to 192.168.0.6 |
There was a problem hiding this comment.
Good examples, particularly showing how comments can be used
|
It may require a separate JIRA ticket for tracking purposes, but I happen to notice just now that the Admin Guide states nifi.provenance.repository.rollover.time is 30 secs, but in reality it appears to be 10 mins (in the default nifi.properties file.) |
Thanks for catching that additional detail and for the feedback on this PR. Given the current scope, I think it would be better to address that in a separate Jira issue with additional context and focus. |
|
Built and installed this branch to confirm the Admin Guide renders as expected. Looks good. |
|
Thanks @exceptionfactory for the update to the admin guide! And thanks for reviewing @markobean. I'm a +1 as well. Merged to main. |
Description of PR
NIFI-8964 Adds a
Cluster Firewall Configurationsection under the generalClustering Configurationheading in the NiFi System Adminstrator's Guide. The section includes an example configuration file showing supported file syntax.In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically
main)?Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not
squashor use--forcewhen pushing to allow for clean monitoring of changes.For code changes:
mvn -Pcontrib-check clean installat the rootnififolder?LICENSEfile, including the mainLICENSEfile undernifi-assembly?NOTICEfile, including the mainNOTICEfile found undernifi-assembly?.displayNamein addition to .name (programmatic access) for each of the new properties?For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.