Skip to content

NIFI-9041 Replaced JUnit 4 only testing configuration with a combinat…#5304

Closed
MikeThomsen wants to merge 5 commits intoapache:mainfrom
MikeThomsen:NIFI-9041
Closed

NIFI-9041 Replaced JUnit 4 only testing configuration with a combinat…#5304
MikeThomsen wants to merge 5 commits intoapache:mainfrom
MikeThomsen:NIFI-9041

Conversation

@MikeThomsen
Copy link
Contributor

…ion of JUnit 5 and JUnit Vintage. Updated nifi-mock to be exclusively JUnit 5 and updated a few modules to demonstrate a successful conversion to all JUnit 5 while the rest of the build is slowly converted to JUnit 5.

Thank you for submitting a contribution to Apache NiFi.

Please provide a short description of the PR here:

Description of PR

Enables X functionality; fixes bug NIFI-YYYY.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on JDK 8?
  • Have you verified that the full build is successful on JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

…ion of JUnit 5 and JUnit Vintage. Updated nifi-mock to be exclusively JUnit 5 and updated a few modules to demonstrate a successful conversion to all JUnit 5 while the rest of the build is slowly converted to JUnit 5.
@MikeThomsen
Copy link
Contributor Author

@exceptionfactory for some reason, I couldn't add you as a requested reviewer.

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together @MikeThomsen! Introducing JUnit 5 support will be very helpful for improving the configuration of things like performance tests. The nifi-mock changes look good, and the other converted modules provide helpful examples. I noted a couple minor questions on some commented lines, but otherwise this looks straightforward.

@MikeThomsen
Copy link
Contributor Author

@exceptionfactory made the changes

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the updates @MikeThomsen.

When reviewing the dependencies in comparison with the JUnit 5 migration example project, I noted some adjustments. In particular, leveraging the JUnit Bill-of-Materials provides consistent version numbering, and declaring a direct dependency on junit-jupiter-api also clarifies what is necessary in nifi-mock.

@MikeThomsen
Copy link
Contributor Author

@exceptionfactory updates made.

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turnaround @MikeThomsen, looks good! +1 Merging.

@asfgit asfgit closed this in 4c6bd85 Aug 12, 2021
@MikeThomsen MikeThomsen deleted the NIFI-9041 branch August 13, 2021 01:14
@MikeThomsen
Copy link
Contributor Author

Thanks for the quick review!

krisztina-zsihovszki pushed a commit to krisztina-zsihovszki/nifi that referenced this pull request Jun 28, 2022
…ion of JUnit 5 and JUnit Vintage.

- Updated nifi-mock to be exclusively JUnit 5
- Updated a few modules to demonstrate a successful conversion to all JUnit 5

This closes apache#5304

Signed-off-by: David Handermann <exceptionfactory@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants