NIFI-9041 Replaced JUnit 4 only testing configuration with a combinat…#5304
NIFI-9041 Replaced JUnit 4 only testing configuration with a combinat…#5304MikeThomsen wants to merge 5 commits intoapache:mainfrom
Conversation
…ion of JUnit 5 and JUnit Vintage. Updated nifi-mock to be exclusively JUnit 5 and updated a few modules to demonstrate a successful conversion to all JUnit 5 while the rest of the build is slowly converted to JUnit 5.
|
@exceptionfactory for some reason, I couldn't add you as a requested reviewer. |
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for putting this together @MikeThomsen! Introducing JUnit 5 support will be very helpful for improving the configuration of things like performance tests. The nifi-mock changes look good, and the other converted modules provide helpful examples. I noted a couple minor questions on some commented lines, but otherwise this looks straightforward.
...ndle/nifi-mongodb-services/src/test/java/org/apache/nifi/mongodb/MongoDBLookupServiceIT.java
Outdated
Show resolved
Hide resolved
...bundle/nifi-mongodb-services/src/main/java/org/apache/nifi/mongodb/MongoDBLookupService.java
Show resolved
Hide resolved
...ndle/nifi-mongodb-services/src/test/java/org/apache/nifi/mongodb/MongoDBLookupServiceIT.java
Outdated
Show resolved
Hide resolved
|
@exceptionfactory made the changes |
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for making the updates @MikeThomsen.
When reviewing the dependencies in comparison with the JUnit 5 migration example project, I noted some adjustments. In particular, leveraging the JUnit Bill-of-Materials provides consistent version numbering, and declaring a direct dependency on junit-jupiter-api also clarifies what is necessary in nifi-mock.
...i-graph-processors/src/test/java/org/apache/nifi/processors/graph/TestExecuteGraphQuery.java
Outdated
Show resolved
Hide resolved
|
@exceptionfactory updates made. |
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for the quick turnaround @MikeThomsen, looks good! +1 Merging.
|
Thanks for the quick review! |
…ion of JUnit 5 and JUnit Vintage. - Updated nifi-mock to be exclusively JUnit 5 - Updated a few modules to demonstrate a successful conversion to all JUnit 5 This closes apache#5304 Signed-off-by: David Handermann <exceptionfactory@apache.org>
…ion of JUnit 5 and JUnit Vintage. Updated nifi-mock to be exclusively JUnit 5 and updated a few modules to demonstrate a successful conversion to all JUnit 5 while the rest of the build is slowly converted to JUnit 5.
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Enables X functionality; fixes bug NIFI-YYYY.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically
main)?Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not
squashor use--forcewhen pushing to allow for clean monitoring of changes.For code changes:
mvn -Pcontrib-check clean installat the rootnififolder?LICENSEfile, including the mainLICENSEfile undernifi-assembly?NOTICEfile, including the mainNOTICEfile found undernifi-assembly?.displayNamein addition to .name (programmatic access) for each of the new properties?For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.