NIFI-9081 Updated nifi-framework-api tests to JUnit 5.#5333
Closed
MikeThomsen wants to merge 2 commits intoapache:mainfrom
Closed
NIFI-9081 Updated nifi-framework-api tests to JUnit 5.#5333MikeThomsen wants to merge 2 commits intoapache:mainfrom
MikeThomsen wants to merge 2 commits intoapache:mainfrom
Conversation
Updated nifi-external tests to JUnit 5. Updated nifi-stateless to use JUnit 5. Updated nifi-api to use JUnit 5.
exceptionfactory
requested changes
Sep 6, 2021
Contributor
exceptionfactory
left a comment
exceptionfactory
left a comment
There was a problem hiding this comment.
This pull request looks close to completion, thanks @MikeThomsen. Just noted to places where fail() inside a try-catch could be replaced with assertThrows, otherwise this looks good.
Comment on lines
131
to
130
| sinkTask.flush(Collections.emptyMap()); | ||
| Assert.fail("Expected RetriableException to be thrown"); | ||
| fail("Expected RetriableException to be thrown"); | ||
| } catch (final RetriableException re) { | ||
| // Expected | ||
| } |
Contributor
There was a problem hiding this comment.
This should be changed to use assertThrows().
Comment on lines
146
to
145
| sourceTask.poll(); | ||
| Assert.fail("Expected RetriableException to be thrown"); | ||
| fail("Expected RetriableException to be thrown"); | ||
| } catch (final RetriableException re) { | ||
| // Expected | ||
| } |
Contributor
There was a problem hiding this comment.
This should be changed to use assertThrows().
Contributor
Author
|
@exceptionfactory changes made. |
Contributor
|
Thanks @MikeThomsen, looks good! +1 Merging. |
Contributor
|
Merged in 6a55c6c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated nifi-external tests to JUnit 5.
Updated nifi-stateless to use JUnit 5.
Updated nifi-api to use JUnit 5.
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Enables X functionality; fixes bug NIFI-YYYY.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically
main)?Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not
squashor use--forcewhen pushing to allow for clean monitoring of changes.For code changes:
mvn -Pcontrib-check clean installat the rootnififolder?LICENSEfile, including the mainLICENSEfile undernifi-assembly?NOTICEfile, including the mainNOTICEfile found undernifi-assembly?.displayNamein addition to .name (programmatic access) for each of the new properties?For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.