NIFI-9183: Add a command-line option to save status history#5356
Closed
Lehel44 wants to merge 11 commits intoapache:mainfrom
Closed
NIFI-9183: Add a command-line option to save status history#5356Lehel44 wants to merge 11 commits intoapache:mainfrom
Lehel44 wants to merge 11 commits intoapache:mainfrom
Conversation
simonbence
requested changes
Sep 6, 2021
Contributor
simonbence
left a comment
There was a problem hiding this comment.
Thanks for the change, especially for extracting the status repository creation! I went through your PR and I found a couple of things I think might be improved. If you have questions I would be more than happy to discuss the given topics.
nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/RunNiFi.java
Outdated
Show resolved
Hide resolved
nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/RunNiFi.java
Outdated
Show resolved
Hide resolved
...work-bundle/nifi-framework/nifi-runtime/src/main/java/org/apache/nifi/BootstrapListener.java
Outdated
Show resolved
Hide resolved
...nifi-framework/nifi-web/nifi-jetty/src/main/java/org/apache/nifi/web/server/JettyServer.java
Outdated
Show resolved
Hide resolved
...nifi-framework/nifi-web/nifi-jetty/src/main/java/org/apache/nifi/web/server/JettyServer.java
Outdated
Show resolved
Hide resolved
simonbence
requested changes
Sep 20, 2021
nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/RunNiFi.java
Outdated
Show resolved
Hide resolved
nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/RunNiFi.java
Outdated
Show resolved
Hide resolved
nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/RunNiFi.java
Outdated
Show resolved
Hide resolved
...framework-api/src/main/java/org/apache/nifi/controller/status/history/StatusHistoryDump.java
Outdated
Show resolved
Hide resolved
...amework/nifi-framework-core/src/test/java/org/apache/nifi/controller/TestFlowController.java
Show resolved
Hide resolved
...framework-core/src/test/java/org/apache/nifi/controller/scheduling/ProcessorLifecycleIT.java
Outdated
Show resolved
Hide resolved
...framework-core/src/test/java/org/apache/nifi/controller/scheduling/ProcessorLifecycleIT.java
Outdated
Show resolved
Hide resolved
...-core/src/test/java/org/apache/nifi/controller/serialization/StandardFlowSerializerTest.java
Outdated
Show resolved
Hide resolved
...ramework/nifi-headless-server/src/main/java/org/apache/nifi/headless/HeadlessNiFiServer.java
Show resolved
Hide resolved
Lehel44
commented
Sep 24, 2021
nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/RunNiFi.java
Outdated
Show resolved
Hide resolved
Lehel44
commented
Sep 24, 2021
...rc/main/java/org/apache/nifi/controller/status/history/JsonNodeStatusHistoryDumpFactory.java
Show resolved
Hide resolved
simonbence
requested changes
Sep 29, 2021
Contributor
simonbence
left a comment
There was a problem hiding this comment.
I had some remarks, please take a look. Also please fix the broken checks.
nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/RunNiFi.java
Outdated
Show resolved
Hide resolved
...framework-api/src/main/java/org/apache/nifi/controller/status/history/StatusHistoryDump.java
Outdated
Show resolved
Hide resolved
...rk-api/src/main/java/org/apache/nifi/controller/status/history/StatusHistoryDumpFactory.java
Outdated
Show resolved
Hide resolved
...-core/src/main/java/org/apache/nifi/controller/status/history/JsonNodeStatusHistoryDump.java
Outdated
Show resolved
Hide resolved
...-framework-core/src/main/java/org/apache/nifi/spring/StatusHistoryRepositoryFactoryBean.java
Outdated
Show resolved
Hide resolved
...amework/nifi-framework-core/src/test/java/org/apache/nifi/controller/TestFlowController.java
Show resolved
Hide resolved
...est/java/org/apache/nifi/controller/status/history/JsonNodeStatusHistoryDumpFactoryTest.java
Show resolved
Hide resolved
...ramework/nifi-headless-server/src/main/java/org/apache/nifi/headless/HeadlessNiFiServer.java
Show resolved
Hide resolved
simonbence
requested changes
Oct 1, 2021
Contributor
simonbence
left a comment
There was a problem hiding this comment.
I made some comments, you might be interested about. Other than that, I kindly ask you to take a look on my previous remarks about HeadlessNiFiServer.
...rk-api/src/main/java/org/apache/nifi/controller/status/history/StatusHistoryDumpFactory.java
Outdated
Show resolved
Hide resolved
nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/RunNiFi.java
Outdated
Show resolved
Hide resolved
nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/util/DumpFileValidator.java
Outdated
Show resolved
Hide resolved
...est/java/org/apache/nifi/controller/status/history/JsonNodeStatusHistoryDumpFactoryTest.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/nifi/controller/status/history/JsonNodeStatusHistoryDumpFactory.java
Outdated
Show resolved
Hide resolved
simonbence
requested changes
Oct 6, 2021
...-framework-core/src/main/java/org/apache/nifi/spring/StatusHistoryRepositoryFactoryBean.java
Outdated
Show resolved
Hide resolved
...ramework/nifi-headless-server/src/main/java/org/apache/nifi/headless/HeadlessNiFiServer.java
Outdated
Show resolved
Hide resolved
simonbence
requested changes
Oct 8, 2021
.../src/main/java/org/apache/nifi/controller/status/history/StatusHistoryRepositoryFactory.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/nifi/controller/status/history/StatusHistoryRepositoryFactory.java
Outdated
Show resolved
Hide resolved
...-framework-core/src/main/java/org/apache/nifi/spring/StatusHistoryRepositoryFactoryBean.java
Outdated
Show resolved
Hide resolved
Contributor
|
LGTM+1 |
Contributor
|
Closing the PR because it was not closed with the merge commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Added command-line option to save status history in JSON.
Details
When you run nifi.sh with a command line option, the RunNiFi class parses the options, creates a NiFi server instance, and sends a request to the BootstrapListener on the server. Objects from nifi-core can be injected by spring web context. Since only a single NiFiServer instance can be accessed in BootstrapListener, I extended it with a new method that returns the status history.
Still under consideration or work in progress:
https://issues.apache.org/jira/browse/NIFI-9183
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically
main)?Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not
squashor use--forcewhen pushing to allow for clean monitoring of changes.For code changes:
mvn -Pcontrib-check clean installat the rootnififolder?LICENSEfile, including the mainLICENSEfile undernifi-assembly?NOTICEfile, including the mainNOTICEfile found undernifi-assembly?.displayNamein addition to .name (programmatic access) for each of the new properties?For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.