NIFI-8491: Adding support for configuring parameter context inheritance#5371
Merged
mcgilman merged 13 commits intoapache:mainfrom Sep 29, 2021
Merged
NIFI-8491: Adding support for configuring parameter context inheritance#5371mcgilman merged 13 commits intoapache:mainfrom
mcgilman merged 13 commits intoapache:mainfrom
Conversation
Contributor
Author
|
I still have a couple of things to close out before this PR is ready for review and merging. However, I'm opening it in its current state to more easily integrate with new endpoints supporting this feature. |
Contributor
|
Reviewing now |
Contributor
|
Nice work, @mcgilman! I was able to successfully build on openjdk version 1.8.0_282. So far, the UI runs well. I'm able to create parameter contexts, add and remove the desired inherited order to use. One error I noticed in the CI build were some frontend linting errors. After you're able to fix these, I will be happy to review again. Thanks! |
- Adding support for configuring parameter context inheritance.
- Allowing changes to the parameter context inheritance to drive Apply disabled state.
- Showing selected inherited parameter contexts in ready only form when appropriate. - Allowing available parameter contexts to be inherited by double clicking. - Removing support for rendering unauthorized inherited parameter contexts as they can no longer be opened.
- Addressing CI failures by rolling back to some order JS language spec to allow yui-compress to minify and compress.
- Ensuring selected context sort order is honored. - Ensuring the Apply button is correctly enabled. - Showing Pending Apply message when selected Parameter Context changes. - Ensuring the Parameter's tab is selected now that there is a third tab.
- Ensuring the available parameter contexts are loaded whether the edit dialog is opened from the listing or outside of the listing.
- Fixing conditions we check if the parameter context listing is currently open.
- Waiting for the parameter contexts to load prior to rendering the parameter context inheritance tab and showing the dialog.
Contributor
Author
|
@mtien-apache Thanks for reviewing! Good catch on the text clipping and the pending message. Will address. |
- Fixing pending apply message clipping. - Hiding pending apply message after clicking Apply.
mtien-apache
approved these changes
Sep 29, 2021
Contributor
mtien-apache
left a comment
mtien-apache
left a comment
There was a problem hiding this comment.
Looks good now! Verified the following:
- I can drag/drop from the "Available Parameter Contexts" to a desired inherited order in the "Selected Parameter Context"
- When I remove from the Selected Param Context, it returns to the Available Param Context that is sorted alphabetically
- While logged in as a restricted user who can only view parameter contexts, I'm able to access the Inheritance tab and it only shows the "read-only" list of Selected Param Context
- Warning message no longer clipped and will disappear once I click "Apply"
Nice work and thanks for the changes, @mcgilman! 👍🏻
krisztina-zsihovszki
pushed a commit
to krisztina-zsihovszki/nifi
that referenced
this pull request
Jun 28, 2022
…ce (apache#5371) * NIFI-8491: - Adding support for configuring parameter context inheritance. * NIFI-8491: - Allowing changes to the parameter context inheritance to drive Apply disabled state. * NIFI-8491: Updating StandardParameterContext#isAuthorized check * NIFI-8491: - Showing selected inherited parameter contexts in ready only form when appropriate. - Allowing available parameter contexts to be inherited by double clicking. - Removing support for rendering unauthorized inherited parameter contexts as they can no longer be opened. * NIFI-8491: Adding inherited param context verification earlier * NIFI-8491: - Addressing CI failures by rolling back to some order JS language spec to allow yui-compress to minify and compress. * NIFI-8491: - Ensuring selected context sort order is honored. - Ensuring the Apply button is correctly enabled. - Showing Pending Apply message when selected Parameter Context changes. - Ensuring the Parameter's tab is selected now that there is a third tab. * Updates to inherited param context verification * Improving validation between parameters/inherited parameters * NIFI-8491: - Ensuring the available parameter contexts are loaded whether the edit dialog is opened from the listing or outside of the listing. * NIFI-8491: - Fixing conditions we check if the parameter context listing is currently open. * NIFI-8491: - Waiting for the parameter contexts to load prior to rendering the parameter context inheritance tab and showing the dialog. * NIFI-8491: - Fixing pending apply message clipping. - Hiding pending apply message after clicking Apply. Co-authored-by: Joe Gresock <jgresock@gmail.com> This closes apache#5371
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NIFI-8491: