Skip to content

add read and write file by fragment and README_ZhCN.md#5394

Closed
OIUE wants to merge 6 commits intoapache:mainfrom
OIUE:main
Closed

add read and write file by fragment and README_ZhCN.md#5394
OIUE wants to merge 6 commits intoapache:mainfrom
OIUE:main

Conversation

@OIUE
Copy link

@OIUE OIUE commented Sep 17, 2021

Thank you for submitting a contribution to Apache NiFi.

Please provide a short description of the PR here:

Description of PR

Enables X functionality; fixes bug NIFI-9224.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • [ NIFI-9224] Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • [ NIFI-9224] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • [ n] Has your PR been rebased against the latest commit within the target branch (typically main)?

  • [ y] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • [ y] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • [ y] Have you written or updated unit tests to verify your changes?
  • [ y] Have you verified that the full build is successful on JDK 8?
  • [ y] Have you verified that the full build is successful on JDK 11?
  • [y ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • [ n] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • [ n] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • [ n] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • [ y] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

@OIUE OIUE closed this Sep 17, 2021
@OIUE OIUE reopened this Sep 17, 2021
@exceptionfactory
Copy link
Contributor

@OIUE Thank you for your contribution.

This pull request in its current form contains multiple merge commits resulting in over 1500 files changed. A new pull request should not contain any merge commits, and changes should be limited to the general scope of the associated Jira issue.

Please open a new pull request with the intended changes squashed into a single commit. That will provide an opportunity to review the intended changes without the confusion related to merge commits and conflicting files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants