Skip to content

NIFI-9275 Upgrade Jetty from 9.4.43 to 9.4.44#5433

Closed
exceptionfactory wants to merge 1 commit intoapache:mainfrom
exceptionfactory:NIFI-9275
Closed

NIFI-9275 Upgrade Jetty from 9.4.43 to 9.4.44#5433
exceptionfactory wants to merge 1 commit intoapache:mainfrom
exceptionfactory:NIFI-9275

Conversation

@exceptionfactory
Copy link
Contributor

Description of PR

NIFI-9275 Upgrades Jetty from 9.4.43 to 9.4.44 across all modules. Updates include replacing individual dependencies with the Jetty Bill-of-Materials dependency to maintain version consistency and avoid unnecessary declarations. The jetty-runner dependency is not covered in jetty-bom and remains as a separate dependency declaration.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on JDK 8?
  • Have you verified that the full build is successful on JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

- Replaced individual Jetty dependencies for jetty-bom
@exceptionfactory
Copy link
Contributor Author

Closing this PR after additional review of the Bill-of-Materials change impacting the explicit configuration of provided scope for several Jetty dependencies. Planning to resubmit a new PR without the BoM changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant