Skip to content

NIFI-9285 Upgrade ZooKeeper transitive version to 3.4.14#5443

Closed
exceptionfactory wants to merge 1 commit intoapache:mainfrom
exceptionfactory:NIFI-9285
Closed

NIFI-9285 Upgrade ZooKeeper transitive version to 3.4.14#5443
exceptionfactory wants to merge 1 commit intoapache:mainfrom
exceptionfactory:NIFI-9285

Conversation

@exceptionfactory
Copy link
Contributor

Description of PR

NIFI-9285 Upgrades transitive dependencies on ZooKeeper 3.4 to 3.4.14. As described in the ZooKeeper releases notes, this version addresses a small number of bug fixes and includes other transitive dependency updates. ZooKeeper client 3.4 is compatible with at least ZooKeeper Server 3.4 and 3.5. This update avoids moving to ZooKeeper 3.5 for now in order to maintain the widest level of compatibility and the least amount of changes.

This change impacts a selected number of NiFi extension components that depend on versions of ZooKeeper between 3.4.5 and 3.4.13.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on JDK 8?
  • Have you verified that the full build is successful on JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

Copy link
Contributor

@gresockj gresockj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @exceptionfactory, the changes look good to me. Looks like this just needs a rebase.

@exceptionfactory
Copy link
Contributor Author

Thanks for the review @gresockj! Rebased and pushed to resolve the conflicts.

Copy link
Contributor

@gresockj gresockj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the rebase! +1

@asfgit asfgit closed this in 9d578e6 Oct 7, 2021
@exceptionfactory exceptionfactory added the hacktoberfest-accepted Hacktoberfest Accepted label Oct 8, 2021
krisztina-zsihovszki pushed a commit to krisztina-zsihovszki/nifi that referenced this pull request Jun 28, 2022
Signed-off-by: Joe Gresock <jgresock@gmail.com>

This closes apache#5443.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted Hacktoberfest Accepted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants