Skip to content

NIFI-9277: Add Record Reader and Writer to ListenHTTP#5446

Closed
Lehel44 wants to merge 4 commits intoapache:mainfrom
Lehel44:NIFI-9277
Closed

NIFI-9277: Add Record Reader and Writer to ListenHTTP#5446
Lehel44 wants to merge 4 commits intoapache:mainfrom
Lehel44:NIFI-9277

Conversation

@Lehel44
Copy link
Contributor

@Lehel44 Lehel44 commented Oct 6, 2021

Thank you for submitting a contribution to Apache NiFi.

Please provide a short description of the PR here:

Description of PR

Added record reader and writer to ListenHTTP processor:

  • Added new record reading/writing properties to ListenHTTP
  • Added validation to ListenHTTP
  • Added Record Reader and Writer to ListenHTTPServlet
  • In case of using an unpacakger and multipart request the record processing is not used
  • Added unit test to TestListenHTTP

JIRA:

https://issues.apache.org/jira/browse/NIFI-9277

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on JDK 8?
  • Have you verified that the full build is successful on JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this new feature @Lehel44! It seems like the primary value of adding a RecordReader is to provide some amount of input request validation that influences the response sent to the client, but it wasn't clear if that was happening. I noted the catching and logging of exceptions in processRecord().

writer.write(record);
}
}
} catch (IOException | MalformedRecordException | SchemaNotFoundException e) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This exception handling seems too broad. MalformedRecordException is probably the only one that should warrant a 400.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The IOException here may be thrown by ReaderFactory::createRecordReader or WriterFactory::createRecordWriter or RecordWriter::write. In case of JsonRecordReader this can be a JsonParseException (which is an IOException). I think in case of IOException we might return with 400 (BAD_REQUEST )return code. I separated the SchemaNotFoundException which returns 500 (INTERNAL_SERVER_ERROR).

@asfgit asfgit closed this in 207894e Oct 15, 2021
@tpalfy
Copy link
Contributor

tpalfy commented Oct 15, 2021

LGTM
Merged into main.

krisztina-zsihovszki pushed a commit to krisztina-zsihovszki/nifi that referenced this pull request Jun 28, 2022
This closes apache#5446.

Signed-off-by: Tamas Palfy <tamas.bertalan.palfy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants