Skip to content

NIFI-9367 Update README.md#5511

Closed
laurentedel wants to merge 5 commits intoapache:mainfrom
laurentedel:main
Closed

NIFI-9367 Update README.md#5511
laurentedel wants to merge 5 commits intoapache:mainfrom
laurentedel:main

Conversation

@laurentedel
Copy link
Contributor

@laurentedel laurentedel commented Nov 5, 2021

how to find generated credentials in the logs
adding default passwords security policy

Thank you for submitting a contribution to Apache NiFi.

Please provide a short description of the PR here:

Description of PR

Enables X functionality; fixes bug NIFI-YYYY.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on JDK 8?
  • Have you verified that the full build is successful on JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

how to find generated credentials in the logs
adding default passwords security policy
@exceptionfactory
Copy link
Contributor

Thanks for the pull request @laurentedel! As noted in the Pull Request checklist, each change requires an associated Jira issue number, so please open an issue in the Apache NiFi Jira board. You can also join the Developers mailing list and request Jira contributor access so that you can assign the issue to yourself. After opening the Jira issue, you can update this pull request to include the Jira number.

@laurentedel
Copy link
Contributor Author

This commit aims to resolve NIFI-9367 for Docker image usage details and clarification

@laurentedel laurentedel changed the title Update README.md NIFI-9367 Update README.md Nov 5, 2021
Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating a Jira issue and updating the pull request @laurentedel. Adding details to the Docker README is a helpful improvement, thanks for the contribution! I made several suggestions to align the wording with the project README.md, and also to correct spelling in a couple places.

laurentedel and others added 4 commits November 9, 2021 10:21
Co-authored-by: exceptionfactory <exceptionfactory@apache.org>
Co-authored-by: exceptionfactory <exceptionfactory@apache.org>
Co-authored-by: exceptionfactory <exceptionfactory@apache.org>
Co-authored-by: exceptionfactory <exceptionfactory@apache.org>
@laurentedel
Copy link
Contributor Author

Thank you for all your very valuable suggestions @exceptionfactory !

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes @laurentedel, the latest updates look good! +1 Merging.

krisztina-zsihovszki pushed a commit to krisztina-zsihovszki/nifi that referenced this pull request Jun 28, 2022
This closes apache#5511

Signed-off-by: David Handermann <exceptionfactory@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants