Skip to content

NIFI-9371 Remove synchronized keyword from Active Threads methods#5513

Merged
markap14 merged 1 commit intoapache:mainfrom
exceptionfactory:NIFI-9371
Nov 10, 2021
Merged

NIFI-9371 Remove synchronized keyword from Active Threads methods#5513
markap14 merged 1 commit intoapache:mainfrom
exceptionfactory:NIFI-9371

Conversation

@exceptionfactory
Copy link
Contributor

Description of PR

NIFI-9371 Removes the synchronized keyword from methods in StandardProcessorNode that interact with the activeThreads ConcurrentHashMap. As a result of changes in #5509 for NIFI-9365, the ConcurrentHashMap provides synchronization around changes to the collection of active threads, making the synchronization unnecessary at the method level.

Additional changes include replacing several System.out.println() statements with SLF4J Logger.info() in nifi-system-test-suite classes.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on JDK 8?
  • Have you verified that the full build is successful on JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

- ConcurrentHashMap collection for Active Threads eliminates the need for method synchronization
- Replaced System.out.println() with Logger.info() in nifi-system-test-suite classes
@markap14
Copy link
Contributor

Thanks @exceptionfactory I agree with the changes, it makes sense to get rid of the synchronized keyword now that the Map was changed to a ConcurrentHashMap. +1 will merge.

@markap14 markap14 merged commit 5aced2b into apache:main Nov 10, 2021
krisztina-zsihovszki pushed a commit to krisztina-zsihovszki/nifi that referenced this pull request Jun 28, 2022
…pache#5513)

- ConcurrentHashMap collection for Active Threads eliminates the need for method synchronization
- Replaced System.out.println() with Logger.info() in nifi-system-test-suite classes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants