NIFI-7862: Add UpdateDatabaseTable processor for auto table structure updates#5523
NIFI-7862: Add UpdateDatabaseTable processor for auto table structure updates#5523mattyb149 wants to merge 6 commits intoapache:mainfrom
Conversation
|
Any progress on this? |
gresockj
left a comment
There was a problem hiding this comment.
Great addition, @mattyb149. Overall the approach looks good, and I noted some minor suggestions. I will test this out later today.
...andard-processors/src/main/java/org/apache/nifi/processors/standard/UpdateDatabaseTable.java
Outdated
Show resolved
Hide resolved
...andard-processors/src/main/java/org/apache/nifi/processors/standard/UpdateDatabaseTable.java
Outdated
Show resolved
Hide resolved
...andard-processors/src/main/java/org/apache/nifi/processors/standard/UpdateDatabaseTable.java
Show resolved
Hide resolved
...andard-processors/src/main/java/org/apache/nifi/processors/standard/UpdateDatabaseTable.java
Outdated
Show resolved
Hide resolved
...andard-processors/src/main/java/org/apache/nifi/processors/standard/UpdateDatabaseTable.java
Outdated
Show resolved
Hide resolved
...andard-processors/src/main/java/org/apache/nifi/processors/standard/UpdateDatabaseTable.java
Show resolved
Hide resolved
...andard-processors/src/main/java/org/apache/nifi/processors/standard/UpdateDatabaseTable.java
Show resolved
Hide resolved
...andard-processors/src/main/java/org/apache/nifi/processors/standard/UpdateDatabaseTable.java
Show resolved
Hide resolved
...andard-processors/src/main/java/org/apache/nifi/processors/standard/UpdateDatabaseTable.java
Outdated
Show resolved
Hide resolved
...andard-processors/src/main/java/org/apache/nifi/processors/standard/UpdateDatabaseTable.java
Outdated
Show resolved
Hide resolved
gresockj
left a comment
There was a problem hiding this comment.
Just a couple comments from my runtime testing.
...andard-processors/src/main/java/org/apache/nifi/processors/standard/UpdateDatabaseTable.java
Show resolved
Hide resolved
...andard-processors/src/main/java/org/apache/nifi/processors/standard/UpdateDatabaseTable.java
Show resolved
Hide resolved
6882567 to
4b6a576
Compare
gresockj
left a comment
There was a problem hiding this comment.
The latest changes look good -- thanks for the updates!
gresockj
left a comment
There was a problem hiding this comment.
Actually, that Windows test failure on the latest run appears to be relevant. I think we should address it before merging.
|
The latest commit didn't fix the errors, going to give it another try tomorrow, once they pass we should be good to go |
|
Looks like the Windows test is passing with the last commit. |
7415ccb to
d531603
Compare
d531603 to
bc38f36
Compare
bc38f36 to
1d8a35c
Compare
|
@gresockj mind taking another look at this one? Please and thanks! |
gresockj
left a comment
There was a problem hiding this comment.
Great, thanks for fixing the unit test on Windows -- looks like a clean build, so I'll go ahead and merge this.
… updates Signed-off-by: Joe Gresock <jgresock@gmail.com> This closes apache#5523.
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Adds functionality like UpdateHive3Table to align records in NiFi with the target table definitions, such as creating a table if it doesn't exist, or adding columns if there are fields in the record that aren't present in the target table. This enables a "data drift" scenario, when data comes in meant for new target tables, or if fields are added at the source.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically
main)?Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not
squashor use--forcewhen pushing to allow for clean monitoring of changes.For code changes:
mvn -Pcontrib-check clean installat the rootnififolder?LICENSEfile, including the mainLICENSEfile undernifi-assembly?NOTICEfile, including the mainNOTICEfile found undernifi-assembly?.displayNamein addition to .name (programmatic access) for each of the new properties?For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.