Skip to content

NIFI-7862: Add UpdateDatabaseTable processor for auto table structure updates#5523

Closed
mattyb149 wants to merge 6 commits intoapache:mainfrom
mattyb149:NIFI-7862_new
Closed

NIFI-7862: Add UpdateDatabaseTable processor for auto table structure updates#5523
mattyb149 wants to merge 6 commits intoapache:mainfrom
mattyb149:NIFI-7862_new

Conversation

@mattyb149
Copy link
Contributor

Thank you for submitting a contribution to Apache NiFi.

Please provide a short description of the PR here:

Description of PR

Adds functionality like UpdateHive3Table to align records in NiFi with the target table definitions, such as creating a table if it doesn't exist, or adding columns if there are fields in the record that aren't present in the target table. This enables a "data drift" scenario, when data comes in meant for new target tables, or if fields are added at the source.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on JDK 8?
  • Have you verified that the full build is successful on JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

@tonykoval
Copy link

Any progress on this?

Copy link
Contributor

@gresockj gresockj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition, @mattyb149. Overall the approach looks good, and I noted some minor suggestions. I will test this out later today.

Copy link
Contributor

@gresockj gresockj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple comments from my runtime testing.

@mattyb149 mattyb149 force-pushed the NIFI-7862_new branch 2 times, most recently from 6882567 to 4b6a576 Compare March 7, 2022 19:50
Copy link
Contributor

@gresockj gresockj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest changes look good -- thanks for the updates!

Copy link
Contributor

@gresockj gresockj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, that Windows test failure on the latest run appears to be relevant. I think we should address it before merging.

@mattyb149
Copy link
Contributor Author

The latest commit didn't fix the errors, going to give it another try tomorrow, once they pass we should be good to go

@mattyb149
Copy link
Contributor Author

Looks like the Windows test is passing with the last commit.

@mattyb149
Copy link
Contributor Author

@gresockj mind taking another look at this one? Please and thanks!

Copy link
Contributor

@gresockj gresockj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for fixing the unit test on Windows -- looks like a clean build, so I'll go ahead and merge this.

@asfgit asfgit closed this in 214bd2f Nov 17, 2022
lizhizhou pushed a commit to lizhizhou/nifi that referenced this pull request Jan 2, 2023
… updates

Signed-off-by: Joe Gresock <jgresock@gmail.com>

This closes apache#5523.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants