Skip to content

NIFI-5821 Add Engine Name to Script Engine Descriptions#5529

Closed
exceptionfactory wants to merge 1 commit intoapache:mainfrom
exceptionfactory:NIFI-5821
Closed

NIFI-5821 Add Engine Name to Script Engine Descriptions#5529
exceptionfactory wants to merge 1 commit intoapache:mainfrom
exceptionfactory:NIFI-5821

Conversation

@exceptionfactory
Copy link
Contributor

Description of PR

NIFI-5821 Updates the allowable value definitions for the Script Engine property in ExecuteScript and related processors to include the Language Version, Engine Name, and Engine Version in the property description. This approach maintains compatibility with current property value definitions based on Language Name and adds important runtime details about the selected script engine.

For example, with the python Language Name, the associated property description reads as follows:

python 2.7 [jython 2.7.1]

The runtime Java Virtual Machine and supporting libraries drive the associated version numbers.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on JDK 8?
  • Have you verified that the full build is successful on JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

@mattyb149
Copy link
Contributor

Reviewing...

@mattyb149
Copy link
Contributor

+1 LGTM, thanks for the improvement! Merging to main

@mattyb149 mattyb149 closed this in d662197 Nov 17, 2021
asfgit pushed a commit that referenced this pull request Dec 14, 2021
Signed-off-by: Matthew Burgess <mattyb149@apache.org>

This closes #5529
krisztina-zsihovszki pushed a commit to krisztina-zsihovszki/nifi that referenced this pull request Jun 28, 2022
Signed-off-by: Matthew Burgess <mattyb149@apache.org>

This closes apache#5529
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants