NIFI-9382: Created a new ClassloaderIsolationKey mechanism by which H…#5533
Merged
bbende merged 3 commits intoapache:mainfrom Nov 22, 2021
Merged
NIFI-9382: Created a new ClassloaderIsolationKey mechanism by which H…#5533bbende merged 3 commits intoapache:mainfrom
bbende merged 3 commits intoapache:mainfrom
Conversation
adenes
suggested changes
Nov 18, 2021
Contributor
adenes
left a comment
There was a problem hiding this comment.
Thanks @markap14 for the change, it definitely makes sense and the approach looks good to me.
Unfortunately right now I don't have capacity to test the functionality. Reading through the PR I had one comment about the name of the ClassloaderIsolationKey interface.
nifi-api/src/main/java/org/apache/nifi/components/ClassloaderIsolationKey.java
Outdated
Show resolved
Hide resolved
bbende
reviewed
Nov 18, 2021
...amework-nar-utils/src/main/java/org/apache/nifi/nar/StandardExtensionDiscoveringManager.java
Outdated
Show resolved
Hide resolved
...amework-nar-utils/src/main/java/org/apache/nifi/nar/StandardExtensionDiscoveringManager.java
Show resolved
Hide resolved
...amework-nar-utils/src/main/java/org/apache/nifi/nar/StandardExtensionDiscoveringManager.java
Outdated
Show resolved
Hide resolved
...nifi-security-kerberos/src/main/java/org/apache/nifi/security/krb/ReentrantKerberosUser.java
Outdated
Show resolved
Hide resolved
…adoop related processors (and potentially others) can indicate that they need full classloaders to be cloned but can share with other instances in certain circumstances - Added system tests
bbende
approved these changes
Nov 22, 2021
Contributor
bbende
left a comment
There was a problem hiding this comment.
Latest updates look good, been running a couple of flows concurrently with different principals and is functioning as expected, going to merge
krisztina-zsihovszki
pushed a commit
to krisztina-zsihovszki/nifi
that referenced
this pull request
Jun 28, 2022
apache#5533) * NIFI-9382: Created a new ClassloaderIsolationKey mechanism by which Hadoop related processors (and potentially others) can indicate that they need full classloaders to be cloned but can share with other instances in certain circumstances - Added system tests * NIFI-9382: Renamed interface based on review feedback * NIFI-9382: Removed ReentrantKerberosUser.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…adoop related processors (and potentially others) can indicate that they need full classloaders to be cloned but can share with other instances in certain circumstances
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Enables X functionality; fixes bug NIFI-YYYY.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically
main)?Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not
squashor use--forcewhen pushing to allow for clean monitoring of changes.For code changes:
mvn -Pcontrib-check clean installat the rootnififolder?LICENSEfile, including the mainLICENSEfile undernifi-assembly?NOTICEfile, including the mainNOTICEfile found undernifi-assembly?.displayNamein addition to .name (programmatic access) for each of the new properties?For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.