Skip to content

NIFI-9411: Adding missing 'setSubtitle' call for Controller Services …#5551

Closed
gresockj wants to merge 1 commit intoapache:mainfrom
gresockj:NIFI-9411
Closed

NIFI-9411: Adding missing 'setSubtitle' call for Controller Services …#5551
gresockj wants to merge 1 commit intoapache:mainfrom
gresockj:NIFI-9411

Conversation

@gresockj
Copy link
Contributor

…modal

Please provide a short description of the PR here:

Adds a missing call to 'setSubtitle' after the initial Controller Service modal has been created.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on JDK 8?
  • Have you verified that the full build is successful on JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

@gresockj gresockj requested a review from andrewmlim November 24, 2021 11:29
@pvillard31
Copy link
Contributor

Followed the steps as described on the JIRA and it's working as expected. Merging. Thanks @gresockj

@asfgit asfgit closed this in dfd8adf Nov 24, 2021
krisztina-zsihovszki pushed a commit to krisztina-zsihovszki/nifi that referenced this pull request Jun 28, 2022
…modal

Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com>

This closes apache#5551.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants