NIFI-9451 add attribute for specifying charset of the incoming flowfi…#5622
NIFI-9451 add attribute for specifying charset of the incoming flowfi…#5622sunyd1224 wants to merge 1 commit intoapache:mainfrom
Conversation
…le contents to PutEmail processor. fix#NIFI-9451
exceptionfactory
left a comment
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for the contribution @sunyd1224! This looks like a straightforward change, but I noted two points where UTF-8 is still hard-coded, should those references also be changed?
| final String messageText = getMessage(flowFile, context, session); | ||
|
|
||
| final String contentType = context.getProperty(CONTENT_TYPE).evaluateAttributeExpressions(flowFile).getValue(); | ||
| final String contentType = context.getProperty(CONTENT_TYPE).evaluateAttributeExpressions(flowFile).getValue().split(";")[0] + "; charset=\"utf-8\""; |
There was a problem hiding this comment.
The split() seems unnecessary, can it be removed? Appending charset="utf-8" implies that the Content Type will always be UTF-8, is that correct?
| Base64.encodeBase64(messageText.getBytes(CONTENT_CHARSET)), contentType + "; charset=\"utf-8\""))); | ||
| Base64.encodeBase64(messageText.getBytes(StandardCharsets.UTF_8)), contentType))); |
There was a problem hiding this comment.
Should StandardCharsets.UTF_8 be replaced with the configured value of Input Character Set?
|
@sunyd1224 Just following up to see if you have had a chance to consider the feedback on this pull request. Thanks! |
|
We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be closed. This stale marker and eventual auto close does not indicate a judgement of the PR just lack of reviewer bandwidth and helps us keep the PR queue more manageable. If you would like this PR re-opened you can do so and a committer can remove the stale tag. Or you can open a new PR. Try to help review other PRs to increase PR review bandwidth which in turn helps yours. |
|
Thanks for the work on this @sunyd1224. Closing in favor of #6193. |
2 participants
…le contents to PutEmail processor. fix#NIFI-9451
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Enables X functionality; fixes bug NIFI-YYYY.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically
main)?Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not
squashor use--forcewhen pushing to allow for clean monitoring of changes.For code changes:
mvn -Pcontrib-check clean installat the rootnififolder?LICENSEfile, including the mainLICENSEfile undernifi-assembly?NOTICEfile, including the mainNOTICEfile found undernifi-assembly?.displayNamein addition to .name (programmatic access) for each of the new properties?For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.