NIFI-9544 - LookupRecord - fixed behavior when no matching value in the LRS#5638
Closed
pvillard31 wants to merge 1 commit intoapache:mainfrom
Closed
NIFI-9544 - LookupRecord - fixed behavior when no matching value in the LRS#5638pvillard31 wants to merge 1 commit intoapache:mainfrom
pvillard31 wants to merge 1 commit intoapache:mainfrom
Conversation
greyp9
approved these changes
Jan 12, 2022
Contributor
greyp9
left a comment
greyp9
left a comment
There was a problem hiding this comment.
Changes look good. Did a couple of spot checks of the updated unit test. LGTM
gresockj
reviewed
Jan 13, 2022
Contributor
gresockj
left a comment
gresockj
left a comment
There was a problem hiding this comment.
I agree with the code change, and in light of @greyp9's review and testing, plan to merge. @pvillard31 can you please rebase since the latest merge conflicts?
Contributor
Author
krisztina-zsihovszki
pushed a commit
to krisztina-zsihovszki/nifi
that referenced
this pull request
Jun 28, 2022
…he LRS Signed-off-by: Joe Gresock <jgresock@gmail.com> This closes apache#5638.
Lehel44
pushed a commit
to Lehel44/nifi
that referenced
this pull request
Jul 1, 2022
…he LRS Signed-off-by: Joe Gresock <jgresock@gmail.com> This closes apache#5638.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Enables X functionality; fixes bug NIFI-YYYY.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically
main)?Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not
squashor use--forcewhen pushing to allow for clean monitoring of changes.For code changes:
mvn -Pcontrib-check clean installat the rootnififolder?LICENSEfile, including the mainLICENSEfile undernifi-assembly?NOTICEfile, including the mainNOTICEfile found undernifi-assembly?.displayNamein addition to .name (programmatic access) for each of the new properties?For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.