Skip to content

NIFI-9563 Enable ListenTCP Pool Receive Buffers property#5653

Closed
exceptionfactory wants to merge 1 commit intoapache:mainfrom
exceptionfactory:NIFI-9563
Closed

NIFI-9563 Enable ListenTCP Pool Receive Buffers property#5653
exceptionfactory wants to merge 1 commit intoapache:mainfrom
exceptionfactory:NIFI-9563

Conversation

@exceptionfactory
Copy link
Copy Markdown
Contributor

Description of PR

NIFI-9563 Removes the deprecation comments from the Pool Receive Buffers property in ListenTCP. Refactoring ListenTCP using Netty removed usage of this property, but it can be repurposed to control the Netty ByteBufAllocator.

The default Netty configuration uses the PooledByteBufAllocator, which aligns with the default value for the Pool Receive Buffers property. Adding a new BufferAllocator enum as a property on NettyEventServerFactory provides the method for changing the Netty Channel Option to use the UnpooledByteBufAllocator when Pool Receive Buffers is disabled in ListenTCP.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on JDK 8?
  • Have you verified that the full build is successful on JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

- Removed deprecation from ListenTCP Pool Receive Buffers property
- Added BufferAllocator configuration property for NettyEventServerFactory
@asfgit asfgit closed this in 7c50f14 Jan 13, 2022
krisztina-zsihovszki pushed a commit to krisztina-zsihovszki/nifi that referenced this pull request Jun 28, 2022
- Removed deprecation from ListenTCP Pool Receive Buffers property
- Added BufferAllocator configuration property for NettyEventServerFactory

Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com>

This closes apache#5653.
Lehel44 pushed a commit to Lehel44/nifi that referenced this pull request Jul 1, 2022
- Removed deprecation from ListenTCP Pool Receive Buffers property
- Added BufferAllocator configuration property for NettyEventServerFactory

Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com>

This closes apache#5653.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants