Skip to content

NIFI-9596: Fix newline bug in JythonScriptRunner#5682

Closed
mattyb149 wants to merge 2 commits intoapache:mainfrom
mattyb149:NIFI-9596
Closed

NIFI-9596: Fix newline bug in JythonScriptRunner#5682
mattyb149 wants to merge 2 commits intoapache:mainfrom
mattyb149:NIFI-9596

Conversation

@mattyb149
Copy link
Copy Markdown
Contributor

Thank you for submitting a contribution to Apache NiFi.

Please provide a short description of the PR here:

Description of PR

There needs to be a newline after all the modules are added via sys.path.append. Updated unit test to exercise the logic.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on JDK 8?
  • Have you verified that the full build is successful on JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

@joewitt
Copy link
Copy Markdown
Contributor

joewitt commented Jan 20, 2022

@mattyb149 Why is it important to remove the header from the test file? Was it critical to verify the scenario under test? If so can we put a comment in that file somewhere indicating this is intentional and/or make it a different test that is so brutally obviously trivial such that a header would be obviously not necessary?

@mattyb149
Copy link
Copy Markdown
Contributor Author

Yes I needed a valid Python statement that wasn't valid on the same line as the first line, and a comment is valid. I can add a comment after the first line to indicate such

@joewitt
Copy link
Copy Markdown
Contributor

joewitt commented Jan 20, 2022

ok fair enough. thanks

Copy link
Copy Markdown
Contributor

@MikeThomsen MikeThomsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@asfgit asfgit closed this in 9d8b395 Feb 2, 2022
krisztina-zsihovszki pushed a commit to krisztina-zsihovszki/nifi that referenced this pull request Jun 28, 2022
NIFI-9596: Added comment to indicate why the Apache header is missing

This closes apache#5682

Signed-off-by: Mike Thomsen <mthomsen@apache.org>
Lehel44 pushed a commit to Lehel44/nifi that referenced this pull request Jul 1, 2022
NIFI-9596: Added comment to indicate why the Apache header is missing

This closes apache#5682

Signed-off-by: Mike Thomsen <mthomsen@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants