Skip to content

NIFI-9586 - exclude assemblies from CI#5690

Closed
greyp9 wants to merge 1 commit intoapache:mainfrom
greyp9:NIFI-9586-D
Closed

NIFI-9586 - exclude assemblies from CI#5690
greyp9 wants to merge 1 commit intoapache:mainfrom
greyp9:NIFI-9586-D

Conversation

@greyp9
Copy link
Contributor

@greyp9 greyp9 commented Jan 20, 2022

Description of PR

Recent CI runs have warned of limited available disk space after build executes.

Windows Zulu JDK 8 FR
You are running out of disk space. The runner will stop working when the machine runs out of disk space. Free space left: 81 MB

Address this by excluding additional *-assembly modules from the CI build.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on JDK 8?
  • Have you verified that the full build is successful on JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

@greyp9
Copy link
Contributor Author

greyp9 commented Jan 20, 2022

The Windows build succeeded (second try) on the source branch:

https://github.com/greyp9/nifi/runs/4888036073

Filesystem           1K-blocks      Used Available Use% Mounted on
C:/Program Files/Git 267921404 177191452  90729952  67% /
D:                    14678012   1904188  12773824  13% /d

Filesystem           1K-blocks      Used Available Use% Mounted on
C:/Program Files/Git 267921404 180197800  87723604  68% /
D:                    14678012  11376304   3301708  78% /d

looks like ~1.5G is saved

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements @greyp9! This makes sense given the current assembly exclusions and definitely helps to reduce the amount of disk utilization during builds. +1 Merging.

krisztina-zsihovszki pushed a commit to krisztina-zsihovszki/nifi that referenced this pull request Jun 28, 2022
This closes apache#5690

Signed-off-by: David Handermann <exceptionfactory@apache.org>
Lehel44 pushed a commit to Lehel44/nifi that referenced this pull request Jul 1, 2022
This closes apache#5690

Signed-off-by: David Handermann <exceptionfactory@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants