NIFI-2098 Adding ignore annotation to testManyFilesOpened unit test#570
Closed
JPercivall wants to merge 1 commit intoapache:0.xfrom
Closed
NIFI-2098 Adding ignore annotation to testManyFilesOpened unit test#570JPercivall wants to merge 1 commit intoapache:0.xfrom
JPercivall wants to merge 1 commit intoapache:0.xfrom
Conversation
Contributor
|
@JPercivall I think this unit test is actually quite helpful to have. It can add a little while to the build process, but it ensures that we don't accidentally hold open the file handles that we are not supposed to hold open. I think the System.out.println() calls need to be replaced with logger calls but don't think we should Ignore the test. If we want to avoid running it too often, we should probably look at making it an integration test instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.